Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10695: old LaTeX does not allow \@ifpackageloaded usage in body #10696

Merged
merged 2 commits into from
Jul 23, 2022

Conversation

jfbu
Copy link
Contributor

@jfbu jfbu commented Jul 23, 2022

Fix #10695
Sorry for oversight, I thought I had tested with a TL2019, but perhaps this was before I added code which uses \@ifpackageloaded in document body. It worked with more recent LaTeX but creates problems with older ones.

@jfbu jfbu added this to the 5.1.0 milestone Jul 23, 2022
@jfbu
Copy link
Contributor Author

jfbu commented Jul 23, 2022

will merge after testing completes and then merge 5.x into master branch

We need to make sure the \put command arguments will expand to a
(fractional) number, so \strip@pt is added, and the \dimexpr properly
closed with \relax
@jfbu
Copy link
Contributor Author

jfbu commented Jul 23, 2022

I identified another problem if LaTeX is old... did not create a separate branch and will merge the two commits after testing completes.

@jfbu jfbu merged commit 40caf0c into sphinx-doc:5.x Jul 23, 2022
@jfbu jfbu deleted the latex_fix_for_old_latex branch July 23, 2022 11:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with ReadTheDocs PDF rendering regarding pict2e LaTeX package
1 participant