Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: example image docker build failures #6

Closed
vdice opened this issue Feb 2, 2024 · 7 comments
Closed

CI: example image docker build failures #6

vdice opened this issue Feb 2, 2024 · 7 comments

Comments

@vdice
Copy link
Contributor

vdice commented Feb 2, 2024

The docker build step for example images are failing (when in 'test' mode). See https://github.com/spinkube/containerd-shim-spin/actions/runs/7759094517/job/21162393271?pr=2 and https://github.com/spinkube/containerd-shim-spin/actions/runs/7759094517/job/21162393801?pr=2

Error snippet:

#13 importing to docker
#13 ERROR: cannot load wasi image on linux
------
 > exporting to docker image format:
------
------
 > importing to docker:
------
ERROR: failed to solve: rpc error: code = Unknown desc = cannot load wasi image on linux
Error: buildx failed with: ERROR: failed to solve: rpc error: code = Unknown desc = cannot load wasi image on linux

It almost seems like we'd need to switch the docker/build-push-action version back to v3 as we do when not in 'test' mode (https://github.com/spinkube/containerd-shim-spin/blob/main/.github/workflows/docker-build-push.yaml#L54-L56).

However, the corresponding workflow in deislabs/containerd-wasm-shims doesn't appear to hit the same error, so I'm confused (see for example https://github.com/deislabs/containerd-wasm-shims/actions/runs/7632914430/job/20794094653)

cc @Mossaka

@Mossaka
Copy link
Member

Mossaka commented Feb 2, 2024

Ummm that's strange

@Mossaka
Copy link
Member

Mossaka commented Feb 2, 2024

It doesn't seem like reverting back to v3 solves the problem (e.g. see this run)

@Mossaka
Copy link
Member

Mossaka commented Feb 3, 2024

Okay, it looks like containerd-wasm-shims hit the same issue; https://github.com/deislabs/containerd-wasm-shims/actions/runs/7763088430/job/21174661154?pr=204

@Mossaka
Copy link
Member

Mossaka commented Feb 3, 2024

The difference between the successful run and unsuccessful run:

containerd: 1.6.27 -> 1.6.28
runc: 1.1.11 -> 1.1.12
docker buildx: 0.11.2 -> 0.12.1

@Mossaka
Copy link
Member

Mossaka commented Feb 5, 2024

@Mossaka
Copy link
Member

Mossaka commented Feb 5, 2024

The solution is to enable containerd image store. See #9

@Mossaka Mossaka closed this as completed Feb 5, 2024
@vdice
Copy link
Contributor Author

vdice commented Feb 6, 2024

👏 Thanks @Mossaka!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants