Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate two Redis trigger test apps #176

Merged

Conversation

kate-goldenring
Copy link
Collaborator

We currently have two redis trigger sample apps but are only using one for tests. This consolidates them and makes it clearer what we are testing.

Ref #165

Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kate-goldenring kate-goldenring force-pushed the consolidate-inbound-redis-apps branch from c27da13 to 9e1dbd9 Compare July 31, 2024 00:53
@kate-goldenring
Copy link
Collaborator Author

@Mossaka I swapped the consolidation to support the Docker builds

@kate-goldenring kate-goldenring force-pushed the consolidate-inbound-redis-apps branch from 9e1dbd9 to efab59d Compare July 31, 2024 04:06
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
@kate-goldenring kate-goldenring force-pushed the consolidate-inbound-redis-apps branch from efab59d to e658965 Compare July 31, 2024 04:08
@kate-goldenring kate-goldenring force-pushed the consolidate-inbound-redis-apps branch 2 times, most recently from f2c1610 to 89741ae Compare August 21, 2024 19:38
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
@kate-goldenring kate-goldenring force-pushed the consolidate-inbound-redis-apps branch from 89741ae to 95bcb99 Compare August 21, 2024 20:37
@kate-goldenring kate-goldenring merged commit 5a7986d into spinkube:main Aug 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants