feat(rfc): plugins ui rfc #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpowell
requested review from
ajordens,
ethanfrogers,
ezimanyi,
plumpy and
robzienert
as code owners
ezimanyi
reviewed
Dec 12, 2019
As promised, I've updated this RFC with my thoughts
Update RFC with new learnings
This incorporates feedback around the initialization section. It also rewrites the bootstrap section, integrating some learnings from a proof of concept that uses the router to delay starting the app
Update plugins-ui.md
Alter wording around Plugin Development and Bootstrap
|
TOC +1. Spirit of the direction is there and we're already well into implementing it. |
robzienert
approved these changes
Jan 23, 2020
plumpy
approved these changes
Jan 23, 2020
ezimanyi
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating this RFC from https://docs.google.com/document/d/16WmRSziTJsSBZ1kuKUfVleLAYMIxmfvz/edit