From 523b65bbbb592b5d378bc4f7ceb3e65bc0be9776 Mon Sep 17 00:00:00 2001
From: spinnakerbot <spinbot@spinnaker.io>
Date: Fri, 29 Mar 2019 11:38:54 -0400
Subject: [PATCH] fix(kubernetes): safe lookups for apiVersion on patch
 manifest deploy status (#6775) (#6781)

---
 .../deployManifest/react/DeployStatus.tsx     | 32 +++++++++++++------
 1 file changed, 23 insertions(+), 9 deletions(-)

diff --git a/app/scripts/modules/kubernetes/src/v2/pipelines/stages/deployManifest/react/DeployStatus.tsx b/app/scripts/modules/kubernetes/src/v2/pipelines/stages/deployManifest/react/DeployStatus.tsx
index ea3fec020bc..9d699d1ea7a 100644
--- a/app/scripts/modules/kubernetes/src/v2/pipelines/stages/deployManifest/react/DeployStatus.tsx
+++ b/app/scripts/modules/kubernetes/src/v2/pipelines/stages/deployManifest/react/DeployStatus.tsx
@@ -10,10 +10,24 @@ import { KubernetesManifestService } from 'kubernetes/v2/manifest/manifest.servi
 import { ManifestStatus } from './ManifestStatus';
 
 // from https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/
-const BUILT_IN_GROUPS = ['', 'core', 'batch', 'apps', 'extensions', 'storage.k8s.io',
-  'apiextensions.k8s.io', 'apiregistration.k8s.io', 'policy', 'scheduling.k8s.io',
-  'settings.k8s.io', 'authorization.k8s.io', 'authentication.k8s.io', 'rbac.authorization.k8s.io',
-  'certifcates.k8s.io', 'networking.k8s.io']
+const BUILT_IN_GROUPS = [
+  '',
+  'core',
+  'batch',
+  'apps',
+  'extensions',
+  'storage.k8s.io',
+  'apiextensions.k8s.io',
+  'apiregistration.k8s.io',
+  'policy',
+  'scheduling.k8s.io',
+  'settings.k8s.io',
+  'authorization.k8s.io',
+  'authentication.k8s.io',
+  'rbac.authorization.k8s.io',
+  'certifcates.k8s.io',
+  'networking.k8s.io',
+];
 
 export interface IManifestSubscription {
   id: string;
@@ -94,7 +108,7 @@ export class DeployStatus extends React.Component<IExecutionDetailsSectionProps,
     // manifest.metadata.namespace doesn't exist if it's a namespace being deployed
     const namespace = (manifest.metadata.namespace || '_').toLowerCase();
     const name = manifest.metadata.name.toLowerCase();
-    const apiVersion = manifest.apiVersion.toLowerCase();
+    const apiVersion = (manifest.apiVersion || '_').toLowerCase();
     // assuming this identifier is opaque and not parsed anywhere. Including the
     // apiVersion will prevent collisions with CRD kinds without having any visible
     // effect elsewhere
@@ -102,11 +116,11 @@ export class DeployStatus extends React.Component<IExecutionDetailsSectionProps,
   }
 
   private apiGroup(manifest: IStageManifest): string {
-    const parts = manifest.apiVersion.split('/');
+    const parts = (manifest.apiVersion || '_').split('/');
     if (parts.length < 2) {
-      return ''
+      return '';
     }
-    return parts[0]
+    return parts[0];
   }
 
   private isCRDGroup(manifest: IStageManifest): boolean {
@@ -118,7 +132,7 @@ export class DeployStatus extends React.Component<IExecutionDetailsSectionProps,
       return upperFirst(manifest.kind) + '.' + this.apiGroup(manifest);
     }
 
-    return upperFirst(manifest.kind)
+    return upperFirst(manifest.kind);
   }
 
   private stageManifestToIManifest(manifest: IStageManifest, account: string): IManifest {