From 5ab83af27cfdbc0d0cbc7b6afec2f601175303ac Mon Sep 17 00:00:00 2001
From: Adam Jordens <adam@jordens.org>
Date: Thu, 19 Oct 2017 20:00:11 -0700
Subject: [PATCH] feat(provider/amazon): Rollback support for PREVIOUS_IMAGE
 strategy (#4291)

Rolling back to a previous image is available iff:
- a `spinnaker:metadata` entity tag exists with `previousServerGroup` details
- there are no other server groups in the cluster/region
---
 .../rollbackServerGroup.controller.js         | 30 +++++++++++++-
 .../details/rollback/rollbackServerGroup.html | 41 +++++++++++++++++--
 2 files changed, 67 insertions(+), 4 deletions(-)

diff --git a/app/scripts/modules/amazon/src/serverGroup/details/rollback/rollbackServerGroup.controller.js b/app/scripts/modules/amazon/src/serverGroup/details/rollback/rollbackServerGroup.controller.js
index 1d5bc44a089..80aefd47b69 100644
--- a/app/scripts/modules/amazon/src/serverGroup/details/rollback/rollbackServerGroup.controller.js
+++ b/app/scripts/modules/amazon/src/serverGroup/details/rollback/rollbackServerGroup.controller.js
@@ -2,6 +2,7 @@
 
 const angular = require('angular');
 
+import { get } from 'lodash';
 import { SERVER_GROUP_WRITER, TASK_MONITOR_BUILDER } from '@spinnaker/core';
 
 module.exports = angular.module('spinnaker.amazon.serverGroup.details.rollback.controller', [
@@ -18,6 +19,28 @@ module.exports = angular.module('spinnaker.amazon.serverGroup.details.rollback.c
 
       var desired = serverGroup.capacity.desired;
 
+      var rollbackType = 'EXPLICIT';
+
+      if (allServerGroups.length === 0 && serverGroup.entityTags) {
+        const previousServerGroup = get(serverGroup, 'entityTags.creationMetadata.value.previousServerGroup');
+        if (previousServerGroup) {
+          rollbackType = 'PREVIOUS_IMAGE';
+          $scope.previousServerGroup = {
+            name: previousServerGroup.name,
+            imageName: previousServerGroup.imageName
+          };
+
+          if (previousServerGroup.imageId && previousServerGroup.imageId !== previousServerGroup.imageName) {
+            $scope.previousServerGroup.imageId = previousServerGroup.imageId;
+          }
+
+          const buildNumber = get(previousServerGroup, 'buildInfo.jenkins.number');
+          if (buildNumber) {
+            $scope.previousServerGroup.buildNumber = buildNumber;
+          }
+        }
+      }
+
       if (desired < 10) {
         var healthyPercent = 100;
       } else if (desired < 20) {
@@ -28,7 +51,7 @@ module.exports = angular.module('spinnaker.amazon.serverGroup.details.rollback.c
       }
 
       $scope.command = {
-        rollbackType: 'EXPLICIT',
+        rollbackType: rollbackType,
         rollbackContext: {
           rollbackServerGroupName: serverGroup.name,
           targetHealthyRollbackPercentage: healthyPercent
@@ -53,6 +76,11 @@ module.exports = angular.module('spinnaker.amazon.serverGroup.details.rollback.c
           return false;
         }
 
+        if (rollbackType === 'PREVIOUS_IMAGE') {
+          // no need to validate when using an explicit image
+          return true;
+        }
+
         return command.rollbackContext.restoreServerGroupName !== undefined;
       };
 
diff --git a/app/scripts/modules/amazon/src/serverGroup/details/rollback/rollbackServerGroup.html b/app/scripts/modules/amazon/src/serverGroup/details/rollback/rollbackServerGroup.html
index 229b1b5ca2e..732e0ccc996 100644
--- a/app/scripts/modules/amazon/src/serverGroup/details/rollback/rollbackServerGroup.html
+++ b/app/scripts/modules/amazon/src/serverGroup/details/rollback/rollbackServerGroup.html
@@ -10,13 +10,25 @@ <h3>Rollback {{serverGroup.name}}</h3>
         <div class="col-sm-3 sm-label-right">
           Restore to
         </div>
-        <div class="col-sm-6">
-          <ui-select ng-model="command.rollbackContext.restoreServerGroupName" class="form-control input-sm">
+        <div class="col-sm-8">
+          <ui-select ng-model="command.rollbackContext.restoreServerGroupName"
+                     class="form-control input-sm"
+                     ng-if="command.rollbackType === 'EXPLICIT'">
             <ui-select-match placeholder="Select...">{{ctrl.label($select.selected)}}</ui-select-match>
             <ui-select-choices group-by="ctrl.group" repeat="serverGroup.name as serverGroup in allServerGroups">
               <span ng-bind-html="ctrl.label(serverGroup)"></span>
             </ui-select-choices>
           </ui-select>
+          <div ng-if="command.rollbackType === 'PREVIOUS_IMAGE'" style="margin-top: 5px">
+            {{ previousServerGroup.name }} <span class="small">(no longer deployed)</span><br/>
+            <span class="small">
+              <strong>Image</strong>: {{ previousServerGroup.imageName}}
+              <span ng-if="previousServerGroup.imageId">({{ previousServerGroup.imageId }})</span><br/>
+            </span>
+            <span class="small" ng-if="previousServerGroup.buildNumber">
+              <strong>Build</strong> #{{ previousServerGroup.buildNumber }}
+            </span>
+          </div>
         </div>
       </div>
 
@@ -52,7 +64,7 @@ <h3>Rollback {{serverGroup.name}}</h3>
           Rollback Operations
         </div>
       </div>
-      <div class="row">
+      <div class="row" ng-if="command.rollbackType === 'EXPLICIT'">
         <div class="col-sm-11 col-sm-offset-1">
           <ol>
             <li>Enable <em>{{ command.rollbackContext.restoreServerGroupName || 'previous server group' }}</em></li>
@@ -76,6 +88,29 @@ <h3>Rollback {{serverGroup.name}}</h3>
           </p>
         </div>
       </div>
+      <div class="row" ng-if="command.rollbackType === 'PREVIOUS_IMAGE'">
+        <div class="col-sm-11 col-sm-offset-1">
+          <ol>
+            <li>Deploy <em>{{ previousServerGroup.imageId }}</em> [
+              <strong>min</strong>: {{serverGroup.capacity.desired}},
+              <strong>max</strong>: {{ serverGroup.capacity.max }},
+              <strong>desired</strong>: {{ serverGroup.capacity.desired }}
+              ]<br/>(minimum capacity pinned at {{serverGroup.capacity.desired}} to prevent autoscaling down during deploy)
+              <li ng-if="command.rollbackContext.targetHealthyRollbackPercentage < 100">
+                Wait for at least {{minHealthy(command.rollbackContext.targetHealthyRollbackPercentage)}}
+                instances to report as healthy
+              </li>
+            </li>
+            <li>Disable {{ serverGroup.name }}</li>
+            <li>Restore minimum capacity of <em>new server group</em> [
+              <strong>min</strong>: {{ serverGroup.capacity.min }}
+              ]</li>
+          </ol>
+          <p>
+            This rollback will affect server groups in {{ serverGroup.account }} ({{ serverGroup.region }}).
+          </p>
+        </div>
+      </div>
 
     </div>
     <aws-footer action="ctrl.rollback()"