From 6b7c1ec0b39359a290511d65421a1ddbb04a9400 Mon Sep 17 00:00:00 2001 From: Chris Berry Date: Wed, 2 Jan 2019 15:49:19 -0800 Subject: [PATCH] fix(core): avoid in sync race condition when saving pipelines (#6235) --- .../modules/core/src/pipeline/config/pipelineConfigurer.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/scripts/modules/core/src/pipeline/config/pipelineConfigurer.js b/app/scripts/modules/core/src/pipeline/config/pipelineConfigurer.js index 84f1b810ac6..6c370bf8b0d 100644 --- a/app/scripts/modules/core/src/pipeline/config/pipelineConfigurer.js +++ b/app/scripts/modules/core/src/pipeline/config/pipelineConfigurer.js @@ -390,11 +390,12 @@ module.exports = angular this.savePipeline = () => { this.setViewState({ saving: true }); - PipelineConfigService.savePipeline($scope.pipeline) + const toSave = _.cloneDeep($scope.pipeline); + PipelineConfigService.savePipeline(toSave) .then(() => $scope.application.pipelineConfigs.refresh(true)) .then( () => { - setOriginal($scope.pipeline); + setOriginal(toSave); markDirty(); this.setViewState({ saving: false }); },