From 9f90ebd8c96b4fcc70b93b7f3d741d4d44bd2c3d Mon Sep 17 00:00:00 2001 From: maggieneterval Date: Thu, 17 Jan 2019 11:23:48 -0500 Subject: [PATCH] fix(google): safe healthcheck lookups when cloning server group --- .../configure/wizard/cloneServerGroup.gce.controller.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/scripts/modules/google/src/serverGroup/configure/wizard/cloneServerGroup.gce.controller.js b/app/scripts/modules/google/src/serverGroup/configure/wizard/cloneServerGroup.gce.controller.js index 56fa3338148..15accace9b2 100644 --- a/app/scripts/modules/google/src/serverGroup/configure/wizard/cloneServerGroup.gce.controller.js +++ b/app/scripts/modules/google/src/serverGroup/configure/wizard/cloneServerGroup.gce.controller.js @@ -373,7 +373,7 @@ module.exports = angular return $uibModalInstance.close($scope.command); } - const healthCheckUrl = $scope.command.autoHealingPolicy.healthCheck; + const healthCheckUrl = _.get($scope.command, 'autoHealingPolicy.healthCheck'); if (healthCheckUrl) { const { healthCheckName, healthCheckKind } = parseHealthCheckUrl(healthCheckUrl); $scope.command.autoHealingPolicy.healthCheck = healthCheckName; @@ -389,7 +389,10 @@ module.exports = angular $scope.command.tags = origTags; $scope.command.loadBalancers = origLoadBalancers; $scope.command.securityGroups = gceTagManager.inferSecurityGroupIdsFromTags($scope.command.tags); - $scope.command.autoHealingPolicy.healthCheck = healthCheckUrl; + + if (healthCheckUrl) { + $scope.command.autoHealingPolicy.healthCheck = healthCheckUrl; + } return promise; });