Skip to content
This repository has been archived by the owner on May 31, 2022. It is now read-only.

[💡FEATURE REQUEST]: Add the ability for SQS plugin to fetch credentials from AWS instead of statically configured empty ones #142

Closed
paulermo opened this issue Dec 2, 2021 · 1 comment · Fixed by #197
Assignees
Labels
C-feature-accepted Feature discussed and accepted P-jobs Plugin: Jobs
Milestone

Comments

@paulermo
Copy link

paulermo commented Dec 2, 2021

SQS plugin while connecting to AWS SQS can use only statically provided in .yaml key & secret. We have pod in AWS EKS which should connect to SQS using IRSA mapping (https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html) and can not store keys in config file to authorize pod. RoadRunner overrides creds fetched automatically with empty ones from config.

AWS SDK provides the ability to fetch credentials from different places and such code is used in RR plugin in consumer.go:111: config.LoadDefaultConfig(). The options which are provided to this call config.WithCredentialsProvider(credentials.NewStaticCredentialsProvider(...)) lead to the fact that credentials fetched from AWS will be rewritten with empty ones. Same - with the region: LoadDefaultConfig can load Region for example from environment variables and empty conf.Region value rewrites it.

We suggest that RR would use static credentials from .yaml file when they are not empty. In other cases leave LoadDefaultConfig() without static creds. Same with the region.

@paulermo paulermo added the C-feature-request Category: feature requested, but need to be discussed label Dec 2, 2021
@rustatian rustatian added C-feature-accepted Feature discussed and accepted P-jobs Plugin: Jobs and removed C-feature-request Category: feature requested, but need to be discussed labels Dec 2, 2021
@rustatian
Copy link
Member

Hey @paulermo . Thanks for the FR. For sure, this feature is important for the use-cases like you, thus, this feature is approved.

@rustatian rustatian added this to the v2.7.0 milestone Dec 2, 2021
@rustatian rustatian changed the title [FEATURE REQUEST] Add the ability for SQS plugin to fetch credentials from AWS instead of statically configured empty ones [💡FEATURE REQUEST]: Add the ability for SQS plugin to fetch credentials from AWS instead of statically configured empty ones Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-feature-accepted Feature discussed and accepted P-jobs Plugin: Jobs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants