Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Overriding default error page #659

Closed
shyim opened this issue May 4, 2021 · 2 comments · Fixed by #700
Closed

[FEATURE REQUEST] Overriding default error page #659

shyim opened this issue May 4, 2021 · 2 comments · Fixed by #700
Assignees
@rustatian
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. C-feature-accepted Category: Feature discussed and accepted Y-Medium Priority: Medium
Milestone
2.3.0

Comments

@shyim
Copy link
Contributor

shyim commented May 4, 2021

Is your feature request related to a problem? Please describe.
If an error happens I see as a client the error. This should be only shown in the development environment

Describe the solution you'd like

Idk something like Internal Server Error like in Apache / Nginx

Describe alternatives you've considered
I am unsure that's possible to catch

image

Additional context
@shyim shyim added the C-feature-request Category: feature requested, but need to be discussed label May 4, 2021
@rustatian
Copy link
Member

Hey @shyim. Yep, we did such override in the RR1 by separating RR errors and application errors. I agree with you. I will plan this update for the next sprint.

@rustatian rustatian added C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. C-feature-accepted Category: Feature discussed and accepted Y-Medium Priority: Medium labels May 4, 2021
@rustatian rustatian removed the C-feature-request Category: feature requested, but need to be discussed label May 4, 2021
@rustatian rustatian added this to the 2.3.0 milestone May 12, 2021
@rustatian
Copy link
Member

ref: #689

@rustatian rustatian mentioned this issue Jun 3, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustatian rustatian

Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. C-feature-accepted Category: Feature discussed and accepted Y-Medium Priority: Medium
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

fix(bug): do not write internal error to the users responseWriter roadrunner-server/roadrunner
2 participants
@shyim @rustatian