Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayoutWriter doesn't respect validity of the top level Struct array #710

Open
robert3005 opened this issue Sep 3, 2024 · 2 comments
Open

Comments

@robert3005
Copy link
Member

Right now if StructArray has top level validity that's not AllValid or NonNullable the validity is discarded

@doki23
Copy link
Contributor

doki23 commented Oct 7, 2024

Could you please provide more details? I'm interested in this issue and would like to attempt to resolve it.

@robert3005
Copy link
Member Author

This is likely not a good first issue. The solution here is likely to either forbid writing top level structs with validity other than nonnullable and provide a function to push validity of the struct to the children, i.e. run a filter. Alternatively we need to teach column layout about one extra validity array which shouldn't be bad but likely unnecessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants