From d542ae8daf0c01bdbc541f80a8560229e9ea62d9 Mon Sep 17 00:00:00 2001
From: J Robert Ray <jrray@jrray.org>
Date: Thu, 25 Aug 2022 18:42:43 -0700
Subject: [PATCH] Add crate-wide config to all crates; customize clippy
 settings

Enable checking of excessive bool parameters in all crates, and limit to 1.
Limit the number of arguments to 5.

Signed-off-by: J Robert Ray <jrray@jrray.org>
---
 .clippy.toml                                                 | 5 +++++
 crates/parsedbuf/src/lib.rs                                  | 1 +
 crates/spfs-cli/cmd-clean/src/cmd_clean.rs                   | 3 +++
 crates/spfs-cli/cmd-enter/src/cmd_enter.rs                   | 3 +++
 crates/spfs-cli/cmd-join/src/cmd_join.rs                     | 3 +++
 crates/spfs-cli/cmd-monitor/src/cmd_monitor.rs               | 3 +++
 crates/spfs-cli/common/src/lib.rs                            | 3 +++
 crates/spfs-cli/main/src/bin.rs                              | 3 +++
 crates/spfs-encoding/src/lib.rs                              | 1 +
 crates/spfs/src/lib.rs                                       | 5 +++--
 crates/spfs/src/resolve_test.rs                              | 5 +++--
 crates/spk-build/src/lib.rs                                  | 3 +++
 crates/spk-cli/cmd-build/src/lib.rs                          | 1 +
 crates/spk-cli/cmd-convert/src/lib.rs                        | 1 +
 crates/spk-cli/cmd-env/src/lib.rs                            | 1 +
 crates/spk-cli/cmd-explain/src/lib.rs                        | 1 +
 crates/spk-cli/cmd-install/src/lib.rs                        | 1 +
 crates/spk-cli/cmd-make-binary/src/lib.rs                    | 1 +
 crates/spk-cli/cmd-make-source/src/lib.rs                    | 1 +
 crates/spk-cli/cmd-render/src/cmd_render.rs                  | 4 ++++
 crates/spk-cli/cmd-render/src/lib.rs                         | 1 +
 crates/spk-cli/cmd-repo/src/lib.rs                           | 1 +
 crates/spk-cli/cmd-test/src/lib.rs                           | 1 +
 crates/spk-cli/common/src/lib.rs                             | 1 +
 crates/spk-cli/group1/src/lib.rs                             | 1 +
 crates/spk-cli/group2/src/lib.rs                             | 1 +
 crates/spk-cli/group3/src/lib.rs                             | 1 +
 crates/spk-cli/group4/src/lib.rs                             | 1 +
 crates/spk-exec/src/lib.rs                                   | 3 +++
 crates/spk-schema/crates/foundation/src/lib.rs               | 1 +
 crates/spk-schema/crates/ident/src/lib.rs                    | 3 +++
 crates/spk-schema/crates/validators/src/lib.rs               | 3 +++
 crates/spk-schema/src/lib.rs                                 | 3 +++
 crates/spk-solve/crates/graph/src/lib.rs                     | 3 +++
 .../spk-solve/crates/package-iterator/src/build_key_test.rs  | 1 +
 crates/spk-solve/crates/package-iterator/src/lib.rs          | 3 +++
 crates/spk-solve/crates/solution/src/lib.rs                  | 3 +++
 crates/spk-solve/crates/validation/src/lib.rs                | 3 +++
 crates/spk-solve/src/lib.rs                                  | 3 +++
 crates/spk-storage/src/lib.rs                                | 3 +++
 crates/spk/src/cli.rs                                        | 4 ++++
 crates/spk/src/lib.rs                                        | 1 +
 42 files changed, 90 insertions(+), 4 deletions(-)
 create mode 100644 .clippy.toml

diff --git a/.clippy.toml b/.clippy.toml
new file mode 100644
index 0000000000..daa211348c
--- /dev/null
+++ b/.clippy.toml
@@ -0,0 +1,5 @@
+# default is 3
+max-fn-params-bools = 1
+
+# default is 7
+too-many-arguments-threshold = 5
\ No newline at end of file
diff --git a/crates/parsedbuf/src/lib.rs b/crates/parsedbuf/src/lib.rs
index ef0f2cb648..2ed0f4c817 100644
--- a/crates/parsedbuf/src/lib.rs
+++ b/crates/parsedbuf/src/lib.rs
@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub use paste;
 
diff --git a/crates/spfs-cli/cmd-clean/src/cmd_clean.rs b/crates/spfs-cli/cmd-clean/src/cmd_clean.rs
index c5acaeabb1..9a00faf36b 100644
--- a/crates/spfs-cli/cmd-clean/src/cmd_clean.rs
+++ b/crates/spfs-cli/cmd-clean/src/cmd_clean.rs
@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use chrono::prelude::*;
 use clap::Parser;
 use colored::*;
diff --git a/crates/spfs-cli/cmd-enter/src/cmd_enter.rs b/crates/spfs-cli/cmd-enter/src/cmd_enter.rs
index e6a40c41b1..e08d99879b 100644
--- a/crates/spfs-cli/cmd-enter/src/cmd_enter.rs
+++ b/crates/spfs-cli/cmd-enter/src/cmd_enter.rs
@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use std::ffi::OsString;
 
 use clap::Parser;
diff --git a/crates/spfs-cli/cmd-join/src/cmd_join.rs b/crates/spfs-cli/cmd-join/src/cmd_join.rs
index db26914008..3c7768f16e 100644
--- a/crates/spfs-cli/cmd-join/src/cmd_join.rs
+++ b/crates/spfs-cli/cmd-join/src/cmd_join.rs
@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use std::ffi::OsString;
 
 use clap::Parser;
diff --git a/crates/spfs-cli/cmd-monitor/src/cmd_monitor.rs b/crates/spfs-cli/cmd-monitor/src/cmd_monitor.rs
index 030f26cf61..77aa01b909 100644
--- a/crates/spfs-cli/cmd-monitor/src/cmd_monitor.rs
+++ b/crates/spfs-cli/cmd-monitor/src/cmd_monitor.rs
@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use std::time::Duration;
 
 use clap::Parser;
diff --git a/crates/spfs-cli/common/src/lib.rs b/crates/spfs-cli/common/src/lib.rs
index 374ef0f90b..e0714ccf3b 100644
--- a/crates/spfs-cli/common/src/lib.rs
+++ b/crates/spfs-cli/common/src/lib.rs
@@ -1,3 +1,6 @@
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 //! Common macros and argument structures for the spfs command line
 
 mod args;
diff --git a/crates/spfs-cli/main/src/bin.rs b/crates/spfs-cli/main/src/bin.rs
index e2fd138630..eff2940461 100644
--- a/crates/spfs-cli/main/src/bin.rs
+++ b/crates/spfs-cli/main/src/bin.rs
@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use clap::{Parser, Subcommand};
 use spfs::Error;
 
diff --git a/crates/spfs-encoding/src/lib.rs b/crates/spfs-encoding/src/lib.rs
index 323cb264cb..b0fc683a75 100644
--- a/crates/spfs-encoding/src/lib.rs
+++ b/crates/spfs-encoding/src/lib.rs
@@ -12,6 +12,7 @@
 
 #![deny(missing_docs)]
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 mod binary;
 mod error;
diff --git a/crates/spfs/src/lib.rs b/crates/spfs/src/lib.rs
index 645ce1d404..41997db65f 100644
--- a/crates/spfs/src/lib.rs
+++ b/crates/spfs/src/lib.rs
@@ -2,9 +2,10 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
-//! Filesystem isolation, capture and distribution.
-
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
+//! Filesystem isolation, capture and distribution.
 
 pub const VERSION: &str = env!("CARGO_PKG_VERSION");
 
diff --git a/crates/spfs/src/resolve_test.rs b/crates/spfs/src/resolve_test.rs
index fe84caaa59..ff5b3d46b3 100644
--- a/crates/spfs/src/resolve_test.rs
+++ b/crates/spfs/src/resolve_test.rs
@@ -1,8 +1,9 @@
-use std::sync::Arc;
-
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
+use std::sync::Arc;
+
 use rstest::rstest;
 
 use super::resolve_stack_to_layers;
diff --git a/crates/spk-build/src/lib.rs b/crates/spk-build/src/lib.rs
index 9b2dd75f39..50b49eb219 100644
--- a/crates/spk-build/src/lib.rs
+++ b/crates/spk-build/src/lib.rs
@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod build;
 mod error;
 
diff --git a/crates/spk-cli/cmd-build/src/lib.rs b/crates/spk-cli/cmd-build/src/lib.rs
index 24106f79f1..74daba1528 100644
--- a/crates/spk-cli/cmd-build/src/lib.rs
+++ b/crates/spk-cli/cmd-build/src/lib.rs
@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_build;
diff --git a/crates/spk-cli/cmd-convert/src/lib.rs b/crates/spk-cli/cmd-convert/src/lib.rs
index a6a2b5b426..6d5a31fc21 100644
--- a/crates/spk-cli/cmd-convert/src/lib.rs
+++ b/crates/spk-cli/cmd-convert/src/lib.rs
@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_convert;
diff --git a/crates/spk-cli/cmd-env/src/lib.rs b/crates/spk-cli/cmd-env/src/lib.rs
index 0997f4aaae..9e64c850a4 100644
--- a/crates/spk-cli/cmd-env/src/lib.rs
+++ b/crates/spk-cli/cmd-env/src/lib.rs
@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_env;
diff --git a/crates/spk-cli/cmd-explain/src/lib.rs b/crates/spk-cli/cmd-explain/src/lib.rs
index 9426fe4767..4a7cf89d95 100644
--- a/crates/spk-cli/cmd-explain/src/lib.rs
+++ b/crates/spk-cli/cmd-explain/src/lib.rs
@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_explain;
diff --git a/crates/spk-cli/cmd-install/src/lib.rs b/crates/spk-cli/cmd-install/src/lib.rs
index 2bd6043b3d..62ad613b2e 100644
--- a/crates/spk-cli/cmd-install/src/lib.rs
+++ b/crates/spk-cli/cmd-install/src/lib.rs
@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_install;
diff --git a/crates/spk-cli/cmd-make-binary/src/lib.rs b/crates/spk-cli/cmd-make-binary/src/lib.rs
index 52966a7863..805cbdba98 100644
--- a/crates/spk-cli/cmd-make-binary/src/lib.rs
+++ b/crates/spk-cli/cmd-make-binary/src/lib.rs
@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_make_binary;
diff --git a/crates/spk-cli/cmd-make-source/src/lib.rs b/crates/spk-cli/cmd-make-source/src/lib.rs
index e4fe48ad5a..defd6d652c 100644
--- a/crates/spk-cli/cmd-make-source/src/lib.rs
+++ b/crates/spk-cli/cmd-make-source/src/lib.rs
@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_make_source;
diff --git a/crates/spk-cli/cmd-render/src/cmd_render.rs b/crates/spk-cli/cmd-render/src/cmd_render.rs
index 8bba1eef33..c0f6fee7e6 100644
--- a/crates/spk-cli/cmd-render/src/cmd_render.rs
+++ b/crates/spk-cli/cmd-render/src/cmd_render.rs
@@ -1,6 +1,10 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use std::path::PathBuf;
 
 use anyhow::{bail, Context, Result};
diff --git a/crates/spk-cli/cmd-render/src/lib.rs b/crates/spk-cli/cmd-render/src/lib.rs
index 1848f62bfb..23a6d536cd 100644
--- a/crates/spk-cli/cmd-render/src/lib.rs
+++ b/crates/spk-cli/cmd-render/src/lib.rs
@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_render;
diff --git a/crates/spk-cli/cmd-repo/src/lib.rs b/crates/spk-cli/cmd-repo/src/lib.rs
index e96e6660ac..cecccef4c8 100644
--- a/crates/spk-cli/cmd-repo/src/lib.rs
+++ b/crates/spk-cli/cmd-repo/src/lib.rs
@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_repo;
diff --git a/crates/spk-cli/cmd-test/src/lib.rs b/crates/spk-cli/cmd-test/src/lib.rs
index 194ec0dd5d..1c97e3b5ef 100644
--- a/crates/spk-cli/cmd-test/src/lib.rs
+++ b/crates/spk-cli/cmd-test/src/lib.rs
@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_test;
 
diff --git a/crates/spk-cli/common/src/lib.rs b/crates/spk-cli/common/src/lib.rs
index 2cbf4173b3..ba920504a9 100644
--- a/crates/spk-cli/common/src/lib.rs
+++ b/crates/spk-cli/common/src/lib.rs
@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 mod cli;
 mod env;
diff --git a/crates/spk-cli/group1/src/lib.rs b/crates/spk-cli/group1/src/lib.rs
index ddd2aba071..5d09f3c4e7 100644
--- a/crates/spk-cli/group1/src/lib.rs
+++ b/crates/spk-cli/group1/src/lib.rs
@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_bake;
 pub mod cmd_deprecate;
diff --git a/crates/spk-cli/group2/src/lib.rs b/crates/spk-cli/group2/src/lib.rs
index a27f4e509f..a13095403b 100644
--- a/crates/spk-cli/group2/src/lib.rs
+++ b/crates/spk-cli/group2/src/lib.rs
@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_ls;
 pub mod cmd_new;
diff --git a/crates/spk-cli/group3/src/lib.rs b/crates/spk-cli/group3/src/lib.rs
index 39d4b29b2d..8c942dd97d 100644
--- a/crates/spk-cli/group3/src/lib.rs
+++ b/crates/spk-cli/group3/src/lib.rs
@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_export;
 pub mod cmd_import;
diff --git a/crates/spk-cli/group4/src/lib.rs b/crates/spk-cli/group4/src/lib.rs
index 41870829a7..124f5ad342 100644
--- a/crates/spk-cli/group4/src/lib.rs
+++ b/crates/spk-cli/group4/src/lib.rs
@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_lint;
 pub mod cmd_search;
diff --git a/crates/spk-exec/src/lib.rs b/crates/spk-exec/src/lib.rs
index 837fd06157..b65ff87ecd 100644
--- a/crates/spk-exec/src/lib.rs
+++ b/crates/spk-exec/src/lib.rs
@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod error;
 mod exec;
 
diff --git a/crates/spk-schema/crates/foundation/src/lib.rs b/crates/spk-schema/crates/foundation/src/lib.rs
index e42ddabb45..54944c91cf 100644
--- a/crates/spk-schema/crates/foundation/src/lib.rs
+++ b/crates/spk-schema/crates/foundation/src/lib.rs
@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod env;
 pub mod fixtures;
diff --git a/crates/spk-schema/crates/ident/src/lib.rs b/crates/spk-schema/crates/ident/src/lib.rs
index 56db543506..47ffddfa1f 100644
--- a/crates/spk-schema/crates/ident/src/lib.rs
+++ b/crates/spk-schema/crates/ident/src/lib.rs
@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod error;
 mod format;
 mod ident;
diff --git a/crates/spk-schema/crates/validators/src/lib.rs b/crates/spk-schema/crates/validators/src/lib.rs
index e8b71d8f41..2a4c782e7b 100644
--- a/crates/spk-schema/crates/validators/src/lib.rs
+++ b/crates/spk-schema/crates/validators/src/lib.rs
@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod error;
 mod validators;
 
diff --git a/crates/spk-schema/src/lib.rs b/crates/spk-schema/src/lib.rs
index 200d98acfb..a7afab91d8 100644
--- a/crates/spk-schema/src/lib.rs
+++ b/crates/spk-schema/src/lib.rs
@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod build_spec;
 mod component_spec;
 mod component_spec_list;
diff --git a/crates/spk-solve/crates/graph/src/lib.rs b/crates/spk-solve/crates/graph/src/lib.rs
index 0b59fb6f7f..09192b68e1 100644
--- a/crates/spk-solve/crates/graph/src/lib.rs
+++ b/crates/spk-solve/crates/graph/src/lib.rs
@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod error;
 mod graph;
 
diff --git a/crates/spk-solve/crates/package-iterator/src/build_key_test.rs b/crates/spk-solve/crates/package-iterator/src/build_key_test.rs
index c16eb73871..2be66d052d 100644
--- a/crates/spk-solve/crates/package-iterator/src/build_key_test.rs
+++ b/crates/spk-solve/crates/package-iterator/src/build_key_test.rs
@@ -34,6 +34,7 @@ fn make_tag_part(pieces: Vec<&str>) -> Option<Vec<BuildKeyVersionNumberPiece>> {
 
 // For making test case results
 #[allow(clippy::too_many_arguments)]
+#[allow(clippy::fn_params_excessive_bools)]
 fn make_expanded_version_range_part(
     version: &str,
     max_digits: Vec<u32>,
diff --git a/crates/spk-solve/crates/package-iterator/src/lib.rs b/crates/spk-solve/crates/package-iterator/src/lib.rs
index db877570cd..79d95f8d39 100644
--- a/crates/spk-solve/crates/package-iterator/src/lib.rs
+++ b/crates/spk-solve/crates/package-iterator/src/lib.rs
@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod build_key;
 mod error;
 mod package_iterator;
diff --git a/crates/spk-solve/crates/solution/src/lib.rs b/crates/spk-solve/crates/solution/src/lib.rs
index a94be42d9c..618a8e7fef 100644
--- a/crates/spk-solve/crates/solution/src/lib.rs
+++ b/crates/spk-solve/crates/solution/src/lib.rs
@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod error;
 mod solution;
 
diff --git a/crates/spk-solve/crates/validation/src/lib.rs b/crates/spk-solve/crates/validation/src/lib.rs
index bc2c2d129c..19515cc4fd 100644
--- a/crates/spk-solve/crates/validation/src/lib.rs
+++ b/crates/spk-solve/crates/validation/src/lib.rs
@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod error;
 mod impossible_checks;
 mod validation;
diff --git a/crates/spk-solve/src/lib.rs b/crates/spk-solve/src/lib.rs
index 8aba7276ef..196ff6fdc0 100644
--- a/crates/spk-solve/src/lib.rs
+++ b/crates/spk-solve/src/lib.rs
@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod error;
 mod io;
 mod macros;
diff --git a/crates/spk-storage/src/lib.rs b/crates/spk-storage/src/lib.rs
index fe8856b475..c9999d3591 100644
--- a/crates/spk-storage/src/lib.rs
+++ b/crates/spk-storage/src/lib.rs
@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod error;
 pub mod fixtures;
 mod storage;
diff --git a/crates/spk/src/cli.rs b/crates/spk/src/cli.rs
index 69e61d4c9a..7b4076e8aa 100644
--- a/crates/spk/src/cli.rs
+++ b/crates/spk/src/cli.rs
@@ -1,6 +1,10 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 //! Main entry points and utilities for command line interface and interaction.
 
 use anyhow::{Context, Result};
diff --git a/crates/spk/src/lib.rs b/crates/spk/src/lib.rs
index 03fdcc431b..fb8548e97a 100644
--- a/crates/spk/src/lib.rs
+++ b/crates/spk/src/lib.rs
@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub use {
     spk_build as build,