Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle new MY_LARGE_SEGMENTS_UPDATE streaming event #328

Merged
merged 6 commits into from
Jul 19, 2024
Merged

Handle new MY_LARGE_SEGMENTS_UPDATE streaming event #328

merged 6 commits into from
Jul 19, 2024

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Jul 17, 2024 •
edited
Loading

JavaScript commons library

What did you accomplish?

  • Add handler for new MY_LARGE_SEGMENTS_UPDATE event, refactoring and reusing the same handler as MY_SEGMENTS_UPDATE_V2, since they share similar update strategies (at the moment, removal and unbound).
  • Updated telemetry to record instant updates from MY_LARGE_SEGMENTS_UPDATE events with removal update strategy.

How do we test the changes introduced in this PR?

  • Unit tests.

Extra Notes

Base automatically changed from SDKS-8407_sync_tasks to SDKS-8407_baseline July 17, 2024 17:07
@EmilianoSanchez EmilianoSanchez marked this pull request as ready for review July 18, 2024 17:49
@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner July 18, 2024 17:49
@EmilianoSanchez EmilianoSanchez merged commit 62db638 into SDKS-8407_baseline Jul 19, 2024
1 check passed
@EmilianoSanchez EmilianoSanchez deleted the SDKS-8407_streaming branch July 19, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmaz90 emmaz90 emmaz90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilianoSanchez @emmaz90