Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large Segment readiness refactors #333

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Large Segment readiness refactors #333

merged 6 commits into from
Jul 25, 2024

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Jul 23, 2024 •
edited
Loading

JavaScript commons library

What did you accomplish?

  • Update MySegmentsFetcher to properly parse payload from /myLargeSegments.
  • A few logic updates to properly handle waitForLargeSegments configuration option.

How do we test the changes introduced in this PR?

  • Unit tests.

Extra Notes

@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner July 23, 2024 21:16
@EmilianoSanchez EmilianoSanchez merged commit 391491b into SDKS-8407_baseline Jul 25, 2024
2 checks passed
@EmilianoSanchez EmilianoSanchez deleted the SDKS-8407_readiness_refactors branch July 25, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gthea gthea gthea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilianoSanchez @gthea