Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large segment refactors #346

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Sep 16, 2024

JavaScript commons library

What did you accomplish?

  • Update IN_LARGE_SEGMENT matcher to use userDefinedLargeSegmentMatcherData property from flag definition.

How do we test the changes introduced in this PR?

Extra Notes

@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner September 16, 2024 20:41
@EmilianoSanchez EmilianoSanchez changed the base branch from development to SDKS-8407_baseline September 16, 2024 20:41
@EmilianoSanchez EmilianoSanchez merged commit f6fa56e into SDKS-8407_baseline Sep 19, 2024
1 check passed
@EmilianoSanchez EmilianoSanchez deleted the SDKS-8407_polishing branch September 19, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants