Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update destroy method #347

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Update destroy method #347

merged 2 commits into from
Sep 20, 2024

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Sep 18, 2024

JavaScript commons library

What did you accomplish?

  • Refactor to clean some code.
  • Update destroy method to stop jobs with the main client destroy call.

How do we test the changes introduced in this PR?

Extra Notes

@EmilianoSanchez EmilianoSanchez marked this pull request as ready for review September 18, 2024 17:12
@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner September 18, 2024 17:12
@EmilianoSanchez EmilianoSanchez merged commit 58e9ad0 into development Sep 20, 2024
2 checks passed
@EmilianoSanchez EmilianoSanchez deleted the update_destroy_method branch September 20, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants