Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a way to initialize with lots of objects #237

Open
guidedways opened this issue Jul 21, 2016 · 1 comment
Open

Allow a way to initialize with lots of objects #237

guidedways opened this issue Jul 21, 2016 · 1 comment

Comments

@guidedways
Copy link

Currently you need to loop over and call addObject for each object that you wish to initialize the token field with. This is a little slow (and painful) since it calls the callback methods on each insert, not to mention it needlessly performs several other checks that aren't necessary at the initialization step. I've got, for example, 20 tokens so add initially. It seems to have turned into a bottleneck which can, I'm sure, be optimized if there was just one addObjects method, that skipped the needless repeated checks and added everything in one go.

@guidedways guidedways changed the title Allow a way to initialize with lots of objects [ENHANCEMENT] Allow a way to initialize with lots of objects Jul 21, 2016
@mgod
Copy link
Contributor

mgod commented Mar 9, 2019

This is still not resolved, but addObjectSync should be much more performant in version 3.0.0

@mgod mgod changed the title [ENHANCEMENT] Allow a way to initialize with lots of objects Allow a way to initialize with lots of objects Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants