Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Github Class doesn't use it's connect block around any of it's api methods #40

Open
anfleene opened this issue Sep 9, 2014 · 2 comments
Open

The Github Class doesn't use it's connect block around any of it's api methods #40

anfleene opened this issue Sep 9, 2014 · 2 comments

Comments

@anfleene
Copy link

anfleene commented Sep 9, 2014

All of the class methods in https://github.com/sportngin/octopolo/blob/master/lib/octopolo/github.rb#L54-L106 aren't using Git.connect to ensure that We can connect to github before running a command.
@chrisarcand
Copy link
Collaborator

Whoa. TIL. Cool I found this while waiting for this PR to go out... 583d927

Yeah, we should definitely do a little inventory and be sure all GitHub calls are wrapped properly. Also a macro for testing invalid tokens would be nice, so you don't have to write out that stub in my above commit each time you need to test something.

@anfleene
Copy link
Author

agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anfleene @chrisarcand