Splitting out okcomputer-contrib

[pbyrne]

We've discussed this in the past, but I'm making an issue for more concentrated conversation. The gem has a lot of tool-specific checks (Resque, Sidekiq, and Delayed Job, and Mongoid) in addition to more generic checks. This raises two questions:

• Does it make sense to split out the tool-specific checks into okcomputer-contrib (which is also freer to include more and more tool-specific checks and go really hog-wild)? Or maybe even okcomputer-resque and so on?
• If that makes sense, does it make sense to do this before bumping to 1.0 and get it all done with?

[pbyrne]

I'm 70% in favor of splitting out, but almost 0% in favor of doing it before bumping to 1.0, which is basically ready to go now.

[pbyrne]

Pinging @anfleene.

[anfleene]

I think we should do it but let's target it for 2.0. I say we bump to 1.0 now and call this current api stable. how does that sound?

[pbyrne]

👍

[pbyrne]

The discussion in #86 (comment) gave me an idea for an alternate take on this: Rather than split it out into its own gem, keep all the checks included in the main gem, but don't require them by default. This would let us accept more checks into the gem (unless they become such a large and unmanageable list that we feel compelled to split them out) without needing a bunch of if defined? or rescue LoadError guards.

Instead, we could build additional, logically named files to require, like okcomputer/resque or okcomputer/mongoid to allow people to opt into loading checks for those libraries. We might even want to require them manually when we detect the constants.

So… it'd look something like this:

• Remove all of our if defined? guards in the built-in checks
• Remove the auto-loading of all built-in checks
  • Load the DB and default checks, though, and the generic checks like SizeThresholdCheck.
• Make files to load all related checks in one fell swoop, like require "okcomputer/resque", require "okcomputer/delayed_job" and the like.
• Update the README with these instructions

[anfleene]

That sounds pretty good. That would also be an easy pattern to use in the future if we do split out gems like a contrib or an okcomputer/resque or whatever.

[johnnyshields]

👍 +1 for splitting out okcomputer-contrib and require "okcomputer/resque" etc. No need for individual gems.