You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 9, 2018. It is now read-only.
Trying to remove the last query parameter with removeQuery while on / and without a basePath defined does not change the path. This is caused by History.send receiving an empty string which results in an empty path argument to window.history.replaceState. I guess this behaviour is correct for the History module, but it is probably wrong in the context of removeQuery.
The following change seems to solve the issue in my application, although there might be some unintended side effects that I'm unaware of:
Trying to remove the last query parameter with removeQuery while on / and without a basePath defined does not change the path. This is caused by History.send receiving an empty string which results in an empty path argument to window.history.replaceState. I guess this behaviour is correct for the History module, but it is probably wrong in the context of removeQuery.
The following change seems to solve the issue in my application, although there might be some unintended side effects that I'm unaware of:
[https://github.com/spektroskop/hop/commit/634a4b2d9b4e02ebc2d48e4836ec12acee7d5107]
If this is an acceptable solution I can submit a pull request.
The text was updated successfully, but these errors were encountered: