From 24841627d3ae7a5a176469700e4c1d13b7c8773a Mon Sep 17 00:00:00 2001 From: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Date: Fri, 8 Jan 2021 22:44:35 +1300 Subject: [PATCH 01/10] Update python-publish.yml --- .github/workflows/python-publish.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/python-publish.yml b/.github/workflows/python-publish.yml index 1ed20a087..a828d5d7d 100644 --- a/.github/workflows/python-publish.yml +++ b/.github/workflows/python-publish.yml @@ -8,7 +8,6 @@ on: types: - created - published - - edited jobs: deploy: From 4c5dd6ebef3be2ff81033727b88dcd96b03bb8c0 Mon Sep 17 00:00:00 2001 From: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Date: Sat, 9 Jan 2021 22:04:22 +1300 Subject: [PATCH 02/10] Update README.md --- README.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index d070ff471..36772f34a 100644 --- a/README.md +++ b/README.md @@ -4,8 +4,14 @@ > The fastest, easiest, and most accurate command-line music downloader -[![MIT License](https://img.shields.io/apm/l/atomic-design-ui.svg?)](https://github.com/spotDL/spotify-downloader/blob/master/LICENSE) ![Contributors](https://img.shields.io/github/contributors/spotDL/spotify-downloader) ![downloads](https://img.shields.io/github/downloads/spotDL/spotify-downloader/latest/total) [![BCH compliance](https://bettercodehub.com/edge/badge/spotDL/spotify-downloader?branch=master)](https://bettercodehub.com/) -[![pypi version](https://img.shields.io/pypi/v/spotDL)](https://pypi.org/project/spotdl/) [![pypi downloads](https://img.shields.io/pypi/dw/spotDL?label=downloads@pypi)](https://pypi.org/project/spotdl/) [![pypi version](https://img.shields.io/pypi/pyversions/spotDL)](https://pypi.org/project/spotdl/) +[![MIT License](https://img.shields.io/apm/l/atomic-design-ui.svg?)](https://github.com/spotDL/spotify-downloader/blob/master/LICENSE) +![Contributors](https://img.shields.io/github/contributors/spotDL/spotify-downloader) +![downloads](https://img.shields.io/github/downloads/spotDL/spotify-downloader/latest/total) +[![BCH compliance](https://bettercodehub.com/edge/badge/spotDL/spotify-downloader?branch=master)](https://bettercodehub.com/) +[![pypi version](https://img.shields.io/pypi/pyversions/spotDL)](https://pypi.org/project/spotdl/) +[![pypi version](https://img.shields.io/pypi/v/spotDL)](https://pypi.org/project/spotdl/) +[![pypi downloads](https://img.shields.io/pypi/dw/spotDL?label=downloads@pypi)](https://pypi.org/project/spotdl/) +[![Discord](https://img.shields.io/discord/771628785447337985.svg?label=&logo=discord&logoColor=ffffff&color=7389D8&labelColor=6A7EC2)](https://discord.gg/xCa23pwJWY) What spotDL does: From 43c709dc4f99f99a96b210d7d43be3686b1d0753 Mon Sep 17 00:00:00 2001 From: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Date: Sat, 9 Jan 2021 22:06:21 +1300 Subject: [PATCH 03/10] Update README.md --- README.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 36772f34a..98f9d817a 100644 --- a/README.md +++ b/README.md @@ -4,13 +4,13 @@ > The fastest, easiest, and most accurate command-line music downloader -[![MIT License](https://img.shields.io/apm/l/atomic-design-ui.svg?)](https://github.com/spotDL/spotify-downloader/blob/master/LICENSE) -![Contributors](https://img.shields.io/github/contributors/spotDL/spotify-downloader) -![downloads](https://img.shields.io/github/downloads/spotDL/spotify-downloader/latest/total) +[![MIT License](https://img.shields.io/apm/l/atomic-design-ui.svg?)](https://github.com/spotDL/spotify-downloader/blob/master/LICENSE) +![Contributors](https://img.shields.io/github/contributors/spotDL/spotify-downloader) +![downloads](https://img.shields.io/github/downloads/spotDL/spotify-downloader/latest/total) [![BCH compliance](https://bettercodehub.com/edge/badge/spotDL/spotify-downloader?branch=master)](https://bettercodehub.com/) -[![pypi version](https://img.shields.io/pypi/pyversions/spotDL)](https://pypi.org/project/spotdl/) -[![pypi version](https://img.shields.io/pypi/v/spotDL)](https://pypi.org/project/spotdl/) -[![pypi downloads](https://img.shields.io/pypi/dw/spotDL?label=downloads@pypi)](https://pypi.org/project/spotdl/) +[![pypi version](https://img.shields.io/pypi/pyversions/spotDL)](https://pypi.org/project/spotdl/) +[![pypi version](https://img.shields.io/pypi/v/spotDL)](https://pypi.org/project/spotdl/) +[![pypi downloads](https://img.shields.io/pypi/dw/spotDL?label=downloads@pypi)](https://pypi.org/project/spotdl/) [![Discord](https://img.shields.io/discord/771628785447337985.svg?label=&logo=discord&logoColor=ffffff&color=7389D8&labelColor=6A7EC2)](https://discord.gg/xCa23pwJWY) What spotDL does: @@ -30,7 +30,7 @@ We rebuilt spotDL from scratch to be faster, simpler, and better than spotDL v2. ⚠ We have dropped the active development of spotDL v2 due to support and maintainability. No focused efforts will be made to resolve v2 specific issues. -#### Join the [spotDL discussion](https://github.com/spotDL/spotify-downloader/discussions?discussions_q=category%3AGeneral)! +### Join the [spotDL Discord!](https://discord.gg/xCa23pwJWY)! ## Installation From 3c4abc1a98b51750c740f1e4bb4feb5e99f23e93 Mon Sep 17 00:00:00 2001 From: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Date: Sat, 9 Jan 2021 22:28:20 +1300 Subject: [PATCH 04/10] Adding Discord Info also adding commits since latest release --- .github/ISSUE_TEMPLATE/config.yml | 5 +++++ .github/ISSUE_TEMPLATE/feature_request.md | 2 ++ README.md | 4 +++- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 3ba13e0ce..cde6a5d4a 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1 +1,6 @@ blank_issues_enabled: false + +contact_links: + - name: spotDL Discord Server! + url: https://discord.gg/xCa23pwJWY + about: Join the spotDL Discord Server \ No newline at end of file diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 5faf8343a..382c1f236 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -10,6 +10,8 @@ assignees: '' + + ## Problem diff --git a/README.md b/README.md index 98f9d817a..ad4d6951c 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,7 @@ # spotDL -> The fastest, easiest, and most accurate command-line music downloader +> **The fastest, easiest, and most accurate command-line music downloader** [![MIT License](https://img.shields.io/apm/l/atomic-design-ui.svg?)](https://github.com/spotDL/spotify-downloader/blob/master/LICENSE) ![Contributors](https://img.shields.io/github/contributors/spotDL/spotify-downloader) @@ -12,6 +12,8 @@ [![pypi version](https://img.shields.io/pypi/v/spotDL)](https://pypi.org/project/spotdl/) [![pypi downloads](https://img.shields.io/pypi/dw/spotDL?label=downloads@pypi)](https://pypi.org/project/spotdl/) [![Discord](https://img.shields.io/discord/771628785447337985.svg?label=&logo=discord&logoColor=ffffff&color=7389D8&labelColor=6A7EC2)](https://discord.gg/xCa23pwJWY) +![GitHub commits since latest release (by date)](https://img.shields.io/github/commits-since/spotDL/spotify-downloader/latest) + What spotDL does: From 1d72ff436508a3c97a5ddbded9257393cb89e337 Mon Sep 17 00:00:00 2001 From: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Date: Sat, 9 Jan 2021 22:29:10 +1300 Subject: [PATCH 05/10] Update bug_report.md --- .github/ISSUE_TEMPLATE/bug_report.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index aa1dcf274..fb1217b74 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -10,6 +10,7 @@ assignees: '' + ### Environment - **System OS:** From 61aafe584837ed7bb0cdf2eaf3714bf309856008 Mon Sep 17 00:00:00 2001 From: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Date: Sat, 9 Jan 2021 22:30:20 +1300 Subject: [PATCH 06/10] Update bug_report.md --- .github/ISSUE_TEMPLATE/bug_report.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index fb1217b74..80795d7f0 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -18,7 +18,7 @@ assignees: '' - **Python Version:** - **Install Source:** - + - **Version OR Commit hash:** From 25a4344166df604ebe6772cbea7d4c09cf69a327 Mon Sep 17 00:00:00 2001 From: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Date: Sat, 9 Jan 2021 22:32:18 +1300 Subject: [PATCH 07/10] Fix BCH config error as per https://bettercodehub.com/docs/configuration-manual --- .bettercodehub.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.bettercodehub.yml b/.bettercodehub.yml index 99d75b7a1..241d3b6b7 100644 --- a/.bettercodehub.yml +++ b/.bettercodehub.yml @@ -10,4 +10,4 @@ component_depth: 3 # Folders to exclude exclude: -- /dev utils/* \ No newline at end of file +- /dev utils/.* \ No newline at end of file From c91b9e8fbaa94b51bb2deaf1d4811aafa388542e Mon Sep 17 00:00:00 2001 From: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Date: Sat, 9 Jan 2021 22:34:17 +1300 Subject: [PATCH 08/10] Update .gitignore --- .gitignore | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index 0ebc60699..a5732773c 100644 --- a/.gitignore +++ b/.gitignore @@ -24,9 +24,7 @@ spotdl.egg-info/* # setuptools and PyInstaller build dist - -# PyInstaller *.spec -# pycharm/intellij +# Jetbrains IDEs; PyCharm/IntelliJ .idea From 1289bd0814e7beb705fa4dc959230847816177ff Mon Sep 17 00:00:00 2001 From: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Date: Sat, 9 Jan 2021 22:35:12 +1300 Subject: [PATCH 09/10] Update CONTRIBUTING.md Started cleaning up contributing.md but will do better in separate branch eventually. --- CONTRIBUTING.md | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 23a7136e5..d5c75cc4c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,25 +1,20 @@ # Which contributions get accepted and which ones don't? -For the sake of maintainability and ease-of-use standards, we can not accept all contributions that -come to spotDL - don't get us wrong, **ALL CONTRIBUTIONS ARE WELCOME...** So just which +For the sake of maintainability and ease-of-use standards, we are not able to accept all contributions that come to spotDL - don't get us wrong, **ALL CONTRIBUTIONS ARE WELCOME...** So just which contributions get accepted and which ones don't? That's what we're here to answer.

# A short note to contributors -1. Further on in this document, we use the term 'Users' interchangeably for both people who use -spotDL as a command line tool and those who use spotDL as a library. +1. Further on in this document, we use the term 'Users' interchangeably for both people who use spotDL as a command line tool and those who use spotDL as a library. -2. These requirements are aimed at helping future contributors (people like you) more than its -aimed at users, code quality and other such things. +2. These requirements are aimed at helping future contributors (people like you) more than its aimed at users, code quality and other such things. -3. Most of the requirements we need for a contribution to be accepted overlap with each other, so -our 5-point requirements is more of a 3.5-point requirements. +3. Most of the requirements we need for a contribution to be accepted overlap with each other, so our 5-point requirements is more of a 3.5-point requirements. -4. Yes, there might be times when you can't both improve spotDL and stick to the requirements, -in those rare cases, focus on improvement first and do your best ot meet the requirements. -Sometimes, you have to take a step back to take several forward. +4. Yes, there might be times when you can't both improve spotDL and stick to the requirements, in those rare cases, focus on improvement first and do your best ot meet the requirements. +ometimes, you have to take a step back to take several forward. 5. Most of the requirements are subjective to an extent. In your view, your code might meet the requirements, in reality, from the experience handling many, many previous contributions, this From 321d87013660c3802e465a8ca244868cb8827754 Mon Sep 17 00:00:00 2001 From: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Date: Sun, 10 Jan 2021 00:12:30 +1300 Subject: [PATCH 10/10] Adding new lines at ends --- .bettercodehub.yml | 2 +- .github/ISSUE_TEMPLATE/config.yml | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.bettercodehub.yml b/.bettercodehub.yml index 241d3b6b7..4f12011d7 100644 --- a/.bettercodehub.yml +++ b/.bettercodehub.yml @@ -10,4 +10,4 @@ component_depth: 3 # Folders to exclude exclude: -- /dev utils/.* \ No newline at end of file +- /dev utils/.* diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index cde6a5d4a..f39d67cd4 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -3,4 +3,5 @@ blank_issues_enabled: false contact_links: - name: spotDL Discord Server! url: https://discord.gg/xCa23pwJWY - about: Join the spotDL Discord Server \ No newline at end of file + about: Join the spotDL Discord Server + \ No newline at end of file