OSError: [Errno 63] File name too long

[fusiller]

Hi,
names can be long ... Just happened to me downloading a file from an old celtic LP ( AR MAHR DALL)

Suggest to insert something like my quick fix :
convertedFileName = convertedFileName[0:250] # slice to avoid os file too long error

just after:
81 : convertedFileName = convertedFileName.replace('"', "'").replace(': ', ' - ')

in downloader.py

One might even try and check the host OS and adjust filename length accordingly : would be much more elegant.

Best regards

[ghost]

Well, cool. Thanks for the heads up. Why don't you open a PR?

[fusiller]

I am not very experienced with how github and the pull request work.
maybe a little shy as well ;)

[ghost]

Haha, that's where I was a few months ago. I'll put up some simple instructions as to how generally go about contributing, weather your contributing here or elsewhere, it should help you out.

Give me till evening.

[ghost]

Well, see this and this.

Please make a draft PR as soon as you start. We'll make sure your code is in-line with our core values, otherwise you might have to do a few of re-writes. And make the PR to next-rel-dev.

Some good PRs to look into:

• @phcreery CLI overhaul (+more) #895 (still in progress, freeq. commits. pretty good time working with him.)
• @s1as3r Added support for downloading artist songs. #904, Added Support for downloads from text files and also added a lyrics provider. #859 (one is still in progress. constant contributor on v3. made some major contributions.)
• @Velovo Adding --quiet #865 (one of the best PRs I've reviewed. She made a good effort to simplify, far more than I expected)

If you're interested in making changes, let us know. If you still have any doubts as to how to contribute, we'll help out. The more contributors, the better spotDL can be. 😁

[ghost]

@fusiller ???