Support Android Gradle Plugin 3.5.3, 3.6.3, 4.0.0 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidburstromspotify
force-pushed
the
master-agp-3.6
branch
3 times, most recently
from
aa587bf to
c531524
Compare
|
@KengoTODA My suggestion regarding the Gradle versions is to bump 5.6 to 5.6.4 for CI, as any project that's still on 5.6 should be updating to 5.6.4 anyway. If that's not agreeable, the functional test would have to be modified to be skipped if Gradle 5.6 is used. |
davidburstromspotify
force-pushed
the
master-agp-3.6
branch
from
c531524 to
a47487a
Compare
KengoTODA
requested changes
May 26, 2020
src/main/groovy/com/github/spotbugs/snom/internal/SpotBugsTaskFactory.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/github/spotbugs/snom/internal/SpotBugsTaskFactory.java
Outdated
Show resolved
Hide resolved
KengoTODA
changed the title
KengoTODA
changed the title
|
Hi @davidburstromspotify, are you gonna work on this? |
|
遅くなってごめんね。I started doing the changes, plus ensuring that AGP 4.0.0 is also supported. |
The misc.xml is updated depending on which version of IntelliJ is in use. The compiler.xml is updated based on local settings. The .iml files gets generated by IntelliJ while importing a Gradle project.
By looping over the variants, it is possible to associate each of them with a given SpotBugs task. Each variant has a compilation task that can be hooked up.
davidburstromspotify
force-pushed
the
master-agp-3.6
branch
from
a47487a to
10073fb
Compare
davidburstromspotify
force-pushed
the
master-agp-3.6
branch
from
10073fb to
16200b2
Compare
davidburstromspotify
changed the title
KengoTODA
approved these changes
Jun 6, 2020
|
🎉 This PR is included in version 4.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233 and #90