Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove STALE event #122

Merged
merged 2 commits into from
Feb 7, 2024
Merged

fix: Remove STALE event #122

merged 2 commits into from
Feb 7, 2024

Conversation

fabriziodemaria
Copy link
Member

The reasons behind this change:

  • This is currently not working as expected, since in case of activateAndFetchAsync the STALE event is emitted even if it shouldn't
  • According to this WIP Proposal, no event is expected prior to "initialize".
  • The STALE event is not meant to indicate a "not-ready cache" anyway: it's meant be used only if the system detects a change of flag evaluation data (for the same evaluation context). From the same PR mentioned above, a new events will be introduced for context reconciliation: PROVIDER_CONTEXT_PENDING and PROVIDER_CONTEXT_CHANGED

Similar to the Swift Provider change: spotify/confidence-sdk-swift#78

Signed-off-by: Fabrizio Demaria <fdema@spotify.com>
Signed-off-by: Fabrizio Demaria <fdema@spotify.com>
@fabriziodemaria fabriziodemaria merged commit 019dbfc into main Feb 7, 2024
2 checks passed
@fabriziodemaria fabriziodemaria deleted the no-stale branch February 7, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants