feat!: total confidence #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahidlazio
requested review from
fabriziodemaria,
mfranberg,
nicklasl,
nickybondarenko and
DennisPersson
as code owners
nicklasl
reviewed
May 28, 2024
vahidlazio
force-pushed
the
total_confidence
branch
from
af885b8
to
b8be61e
Compare
nicklasl
reviewed
May 28, 2024
| @@ -40,7 +40,7 @@ The flag's schema is validated against the requested data type, and if it doesn' | |||
|
|
|||
| ```python | |||
|
|
|||
| from confidence.provider import Region | |||
| from confidence.confidence import Region | |||
There was a problem hiding this comment.
Let's remember to update the readme to surface the Confidence-API's first and foremost.
nicklasl
reviewed
May 28, 2024
nicklasl
reviewed
May 28, 2024
nicklasl
reviewed
May 28, 2024
nicklasl
reviewed
May 28, 2024
nicklasl
reviewed
May 28, 2024
| event_url = "https://events.confidence.dev/v1/events:publish" | ||
| headers = {"Content-Type": "application/json", "Accept": "application/json"} | ||
| response = requests.post(event_url, json=request_body, headers=headers) | ||
| response.raise_for_status() |
There was a problem hiding this comment.
I think we need to figure out how to handle the response using some logging to signal if things are not being accepted.
nicklasl
reviewed
May 28, 2024
nicklasl
reviewed
May 28, 2024
nicklasl
reviewed
May 28, 2024
nicklasl
reviewed
May 28, 2024
nicklasl
reviewed
May 28, 2024
nicklasl
reviewed
May 28, 2024
vahidlazio
force-pushed
the
total_confidence
branch
from
ff23c1f
to
ffff91b
Compare
vahidlazio
commented
May 29, 2024
nicklasl
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.