Significant parameters shown in GUI.

[hirolau]

The docs state: "An insignificant Parameter might also be used to specify a password or other sensitive information that should not be made public via the scheduler"

However, given this code:

class Test(luigi.Task):
    user = luigi.Parameter(significant=True)
    password = luigi.Parameter(significant=False)

    def complete(self):
      return False
    def run(self):
      pass

if __name__ == '__main__':
    luigi.run(['Test','--user','myself','--password','123456'])

In the GUI when looking at the task I see: "user=myself, password=123456". The password is not hidden.

B:\luigi\code>pip show luigi
Name: luigi
Version: 2.6.2

[dckc]

FWIW: I worked around this by moving the password to an environment variable and using the parameter to name the environment variable.

[aldanor]

I'm also wondering about this. Could insignificant parameters be hidden from the GUI?

[langelgjm]

Title should be "Insignificant parameters shown in GUI"

I think the culprit is that in several places, the Task.to_str_params() method is called with the default only_significant=False argument.

E.g., in notifications.py, an e-mail body is created that would include insignificant parameters in plain text.

Contrast this with deps_tree.py which excludes insignificant parameters.

Anything that is going to be displayed for visualization/notification should exclude insignificant / only include significant parameters.

[rhaarm]

Is someone working on a PR for this?

[uatach]

This still happens, any news?

[dlstadther]

@edsonduarte1990 There have been many differing opinions around this (and the similar). For the open PR i'm aware of, see #2278

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If closed, you may revisit when your time allows and reopen! Thank you for your contributions.

[dlstadther]

Closing, given the merge of #2278