Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using Github's CODEOWNERS #2360

Closed
jamesmcm opened this issue Feb 22, 2018 · 3 comments
Closed

Consider using Github's CODEOWNERS #2360

jamesmcm opened this issue Feb 22, 2018 · 3 comments

Comments

@jamesmcm
Copy link
Contributor

See: https://github.com/blog/2392-introducing-code-owners
and
https://help.github.com/articles/about-codeowners/

This could be useful for making pull requests to know who should review which parts of the code (especially contrib modules).

It might also make it easier for newcomers to contact developers regarding their own patches, etc.

@dlstadther
Copy link
Collaborator

I briefly thought about this when GH published that blog post. I want to say it's a good idea to implement in hopes that auto assigning reviewers will aid in quicker PR reviews and merges - thus sparking luigi dev again; however, there exists some overhead in denoting/assigning these code owners - particularly for files with many contributors (i.e. 41 individuals have contributed to parameter.py).

All this said, I think it's worth trying - perhaps start with repo owners and contrib dir.

Thanks for starting this discussion!

@stale
Copy link

stale bot commented Jul 31, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If closed, you may revisit when your time allows and reopen! Thank you for your contributions.

@stale stale bot added the wontfix label Jul 31, 2018
@dlstadther
Copy link
Collaborator

Resolved by #2465

The initial take was only at global owners and my redshift ownership. Contributions welcome :)

@stale stale bot removed the wontfix label Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants