Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added chicken param to remove methods, consistent apis #714

Closed
wants to merge 1 commit into from

Conversation

coderfi
Copy link

@coderfi coderfi commented Feb 5, 2015

such as mkdir and remove

@coderfi
Copy link
Author

coderfi commented Feb 5, 2015

This is the follow up to my epic fail of a Pull Request #628 (which was also a fail for Pull Request #615).

Thanks for your help!

-Fi

@Tarrasch
Copy link
Contributor

Tarrasch commented Feb 5, 2015

Can you make Travis happy? :)

@erikbern
Copy link
Contributor

erikbern commented Feb 5, 2015

Can you also add some tests?

@landscape-bot
Copy link

Code Health
Repository health increased by 0.18% when pulling 6b0018a on coderfi:master into d27cde2 on spotify:master.

@coderfi
Copy link
Author

coderfi commented Feb 6, 2015

Sure. I'll move the doctests out to somewhere your test harness can find.

Fi
On Feb 5, 2015 3:50 AM, "Erik Bernhardsson" notifications@github.com
wrote:

Can you also add some tests?


Reply to this email directly or view it on GitHub
#714 (comment).

@MartinXu
Copy link

can we have a quick start or detailed install doc for new user?

@Tarrasch
Copy link
Contributor

@MartinXu Do you mean in general or for this particular Pull Request???

@erikbern erikbern closed this Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants