support repeated leafs in BigtableType #255 #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
==========================================
+ Coverage 96.38% 96.47% +0.09%
==========================================
Files 38 38
Lines 1189 1220 +31
Branches 49 53 +4
==========================================
+ Hits 1146 1177 +31
Misses 43 43
Continue to review full report at Codecov.
|
stormy-ua
reviewed
Feb 24, 2021
| v.toSeq.flatMap(btf.put(k, _)(cm)) | ||
| } | ||
|
|
||
| implicit def btfIterable[T, C[T]](implicit |
There was a problem hiding this comment.
Nice! Now we can store iterables in a cell 🎉
stormy-ua
reviewed
Feb 24, 2021
| case None => | ||
| (1 to n).foreach { _ => | ||
| val s = buf.getInt | ||
| val ba = new Array[Byte](s) |
There was a problem hiding this comment.
I wonder if we need to handle the case with an empty string somehow explicitly, but you have added a test for Repeated so looks like it should work.
There was a problem hiding this comment.
Yeah, arrays can be empty, and scalacheck should generate "" cases.
nevillelyh
force-pushed
the
neville/bt-repeated
branch
from
4f86ddd
to
dfc882a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.