From 072ef462f211af8044950945f7e1514b55f69cfc Mon Sep 17 00:00:00 2001 From: Kellen Dye Date: Wed, 20 Dec 2023 09:17:32 -0500 Subject: [PATCH] wip --- .../main/scala/com/spotify/scio/values/SideInput.scala | 2 +- .../scala/com/spotify/scio/extra/sparkey/SparkeyIO.scala | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/scio-core/src/main/scala/com/spotify/scio/values/SideInput.scala b/scio-core/src/main/scala/com/spotify/scio/values/SideInput.scala index 06e78ad6e6..a12000f8f5 100644 --- a/scio-core/src/main/scala/com/spotify/scio/values/SideInput.scala +++ b/scio-core/src/main/scala/com/spotify/scio/values/SideInput.scala @@ -130,7 +130,7 @@ private[values] class MultiMapSideInput[K, V](val view: PCollectionView[JMap[K, @deprecated(since = "0.14.0") private[values] class DelegatingSideInput[A, B](val si: SideInput[A], val mapper: A => B) - extends SideInput[B] { + extends SideInput[B] { // Only update the cached value (and re-run the mapper) if the underlying SI does the same. override protected[values] def updateCacheOnGlobalWindow: Boolean = si.updateCacheOnGlobalWindow diff --git a/scio-extra/src/main/scala/com/spotify/scio/extra/sparkey/SparkeyIO.scala b/scio-extra/src/main/scala/com/spotify/scio/extra/sparkey/SparkeyIO.scala index 1f84e1151c..e5430c9851 100644 --- a/scio-extra/src/main/scala/com/spotify/scio/extra/sparkey/SparkeyIO.scala +++ b/scio-extra/src/main/scala/com/spotify/scio/extra/sparkey/SparkeyIO.scala @@ -29,10 +29,10 @@ case class SparkeyIOOutput[K, V](path: String) extends TestIO[(K, V)] { object SparkeyIO { private val logger = LoggerFactory.getLogger(this.getClass) - private[sparkey] val DefaultNumShards: Short = 1 - private[sparkey] val DefaultSideInputNumShards: Short = 64 - private[sparkey] val DefaultCompressionType: CompressionType = CompressionType.NONE - private[sparkey] val DefaultCompressionBlockSize: Int = 0 + val DefaultNumShards: Short = 1 + val DefaultSideInputNumShards: Short = 64 + val DefaultCompressionType: CompressionType = CompressionType.NONE + val DefaultCompressionBlockSize: Int = 0 def output[K, V](path: String): SparkeyIOOutput[K, V] = SparkeyIOOutput[K, V](path)