Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples use request library, which has been deprecated. #49

Open
scowalt opened this issue Apr 7, 2020 · 5 comments
Open

Examples use request library, which has been deprecated. #49

scowalt opened this issue Apr 7, 2020 · 5 comments

Comments

@scowalt
Copy link

scowalt commented Apr 7, 2020

The request library is use in these examples to perform network requests from a node server instance.

This library has been deprecated.

This post suggests some alternative libraries to use. I personally would recommend node-fetch, since it matches the known fetch API from browsers and uses promises.

@terryjiang2020
Copy link

Can't believe it has been 2 years and no one has considered updating this.

@eebmagic
Copy link

I'd also hope to see this get updated.

@eebmagic
Copy link

I just made a pull request for this issue:
#87

@scowalt @terryjiang2020 I would appreciate if either of you could take a look at it to check if it looks good.

@eebmagic
Copy link

@zhenyu0519 Why was your pull request for this closed?

@eebmagic
Copy link

@perploug I'm not sure if anyone is really assigned to maintain this repo internally at Spotify anymore, but saw that you made a commit recently. Could you merge my pull request or find someone who could?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants