From 3572c30a4eaca63dc7311b85cd0444f09263bf5e Mon Sep 17 00:00:00 2001
From: Arild Matsson <arild.matsson@gu.se>
Date: Tue, 24 Sep 2024 15:34:53 +0200
Subject: [PATCH] style: clearer caution next to config custom upload

---
 CHANGELOG.md                             |  1 +
 src/corpus/config/CorpusConfigCustom.vue | 10 +++++++++-
 src/i18n/locales/en.yaml                 |  3 ++-
 src/i18n/locales/sv.yaml                 |  3 ++-
 4 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ee7725d..9a83b48 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -22,6 +22,7 @@ As this project is a user-facing application, the places in the semantic version
 
 - Improved repo documentation
 - Replaced Font Awesome with Phosphor Icons
+- Clearer message of caution next to custom config upload form
 
 ### Fixed
 
diff --git a/src/corpus/config/CorpusConfigCustom.vue b/src/corpus/config/CorpusConfigCustom.vue
index 8415d53..e125197 100644
--- a/src/corpus/config/CorpusConfigCustom.vue
+++ b/src/corpus/config/CorpusConfigCustom.vue
@@ -1,5 +1,6 @@
 <script setup lang="ts">
 import type { AxiosError } from "axios";
+import { PhWarning } from "@phosphor-icons/vue";
 import useCorpusIdParam from "@/corpus/corpusIdParam.composable";
 import useConfig from "@/corpus/config/config.composable";
 import { useAuth } from "@/auth/auth.composable";
@@ -53,7 +54,14 @@ async function upload(files: File[]) {
     </LayoutBox>
 
     <LayoutBox class="w-96 grow" :title="$t('upload')">
-      <HelpBox>{{ $t("config.custom.upload.help") }}</HelpBox>
+      <HelpBox important>
+        <PhWarning class="inline mb-1 mr-1" />
+        {{ $t("config.custom.upload.caution") }}
+      </HelpBox>
+      <HelpBox important>
+        <PhWarning class="inline mb-1 mr-1" />
+        {{ $t("config.custom.upload.overwrite") }}
+      </HelpBox>
       <PendingContent :on="`corpus/${corpusId}/config`" blocking>
         <FileUpload :file-handler="upload" accept=".yaml,.yml" />
       </PendingContent>
diff --git a/src/i18n/locales/en.yaml b/src/i18n/locales/en.yaml
index 6f25f90..a50d161 100644
--- a/src/i18n/locales/en.yaml
+++ b/src/i18n/locales/en.yaml
@@ -193,7 +193,8 @@ metadata.description.help: |
 fileFormat: Source format
 config.custom: Custom configuration
 config.custom.help: Mink uses {sparv}, a modular and configurable pipeline for text analysis, to process your corpus. The standard configuration form only exposes a few of the available Sparv options. On this page, you can view and submit your own config file, written in the YAML format. Please refer to the Sparv documentation on {topic} for more information.
-config.custom.upload.help: Please note that submitting an invalid config file may cause unexpected behaviour. Saving the standard configuration form may overwrite your custom config.
+config.custom.upload.caution: Please note that submitting an invalid config file may cause unexpected behaviour.
+config.custom.upload.overwrite: Saving the standard configuration form may overwrite your custom config.
 config.format.help: Select the file format of the source texts. All files must be of the selected format.
 config.format.note.pdf: The PDF file format is primarily designed for display. Please note that extracting text from them can sometimes give unsatisfactory results. Performing OCR on scanned documents is (currently) outside the scope of Mink.
 config.text_annotation: Text element
diff --git a/src/i18n/locales/sv.yaml b/src/i18n/locales/sv.yaml
index c0f985d..c492f4b 100644
--- a/src/i18n/locales/sv.yaml
+++ b/src/i18n/locales/sv.yaml
@@ -194,7 +194,8 @@ metadata.description.help: |
 fileFormat: Källformat
 config.custom: Egen konfiguration
 config.custom.help: Mink använder {sparv}, en modulär och konfigurerbar pipeline för textanalys, för att processa korpusen. Det vanliga formuläret visar endast en liten del av alla inställningar. På den här sidan kan du undersöka den faktiska configfilen och ladda upp en egen, i formatet YAML. Använd Sparvdokumentationens avsnitt {topic} för att tolka filens struktur.
-config.custom.upload.help: Notera att en ogiltig configfil kan leda till oväntat beteende. Om du sparar i det vanliga formuläret igen kan den egna konfigurationen skrivas över.
+config.custom.upload.caution: Notera att en ogiltig configfil kan leda till oväntat beteende.
+config.custom.upload.overwrite: Om du sparar i det vanliga formuläret igen kan den egna konfigurationen skrivas över.
 config.format.help: Ange vilket filformat källtexterna har. Alla filer måste ha det valda formatet.
 config.format.note.pdf: PDF-formatet är byggt främst för visuell presentation. Text som extraheras från PDF-filer kan ibland ge bristfälliga resultat. OCR-behandling av scannade dokument är (för närvarande) inget som Mink stödjer.
 config.text_annotation: Textelement