Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3-0-stable refund view is no longer working due to current_symbol_position is no longer an preference option in spree #170

Closed
simontseng opened this issue Jul 6, 2015 · 4 comments
Closed

3-0-stable refund view is no longer working due to current_symbol_position is no longer an preference option in spree #170

simontseng opened this issue Jul 6, 2015 · 4 comments

Comments

@simontseng
Copy link
Contributor

I found 3-0-stable refund view is no longer working due to current_symbol_position is no longer an preference option in spree.

I removed the if statement around it so that it is display just as if it is with option "before" for the current_symbol_position.

Quick investigation, looks like spree is move the options into spree_i18n which is an addon that is not installed by default.

I don't mind to submit a PR but need some pointers showing what's the best way to do it.
This was referenced Jul 6, 2015
Open
Closed
@mleglise
Copy link

mleglise commented Jul 8, 2015

+1

1 similar comment
@giupea
Copy link

giupea commented Jul 9, 2015

+1

@simontseng simontseng mentioned this issue Jul 10, 2015
Merged
@simontseng
Copy link
Contributor Author

just tried to submit an PR
#174

@alepore
Copy link
Member

alepore commented Jul 13, 2015

#174 merged

@alepore alepore closed this as completed Jul 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mleglise @alepore @simontseng @giupea