Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tracing From a non-spring application to a spring/sleuth one: Need some validation #537

Closed
dom-42 opened this issue Mar 3, 2017 · 8 comments
Labels

Comments

@dom-42
Copy link

dom-42 commented Mar 3, 2017

Hi

I have a non spring application (an ESB indeed) which has its own trace mechanism (w/traceid and spanid ;) ).
This application writes to a kafka topic consumed by a regular spring stream/sleuth microservice. I added simili sleuth headers to this topic (spanTraceId=myTraceId, spanId=myTopicId, aso ...) in order to get E2E tracing mechanism and leverage sleuth implementation where it's available.

This seems to work, sleuth recognize my headers and create new spans attached to my own trace.
Question is, do you think this approach is a good one or should I use another mechanism ?

Thank you for your help.

@marcingrzejszczak
Copy link
Contributor

marcingrzejszczak commented Mar 3, 2017

Yeah it seems like a good idea. If you create on this topic messages that Sleuth Stream understands then it's perfectly fine. That's the idea of the interop. If your app sends Sleuth compatible headers - that's perfectly fine.

@dom-42
Copy link
Author

dom-42 commented Mar 3, 2017

Hi Marcin

Great. Thank you. No specific format to respect anyway ?

@marcingrzejszczak
Copy link
Contributor

@dom-42
Copy link
Author

dom-42 commented Mar 3, 2017

Perfect, will keep same formats then.
Thx

@ashwgupt
Copy link

ashwgupt commented Mar 8, 2017

If one is using a language that has http://opentracing.io supported libraries, should not one use that instead?

@marcingrzejszczak
Copy link
Contributor

You can check out this issue #253 for more info about this. We've initially decided to pick a different transport format for sending spans via messaging and currently the plan to change it is low in terms of priority. You can always run our collector and store spans to the same DB as other collectors.

@dom-42
Copy link
Author

dom-42 commented Mar 8, 2017

Hi

@ashwgupt: not in our use case: we already use Sleuth tracing mechanism within our Spring Cloud applications but upstream and downstream we use components that don't rely on Spring (WSO2 ESB e.g.).
In order to get E2E tracing, we had to find a bi-directional solution which propagates Sleuth headers from and to these components.

@marcingrzejszczak
Copy link
Contributor

BTW let's differentiate 2 things here - one is tracing headers in messages and the other format of spans. Tracing headers in messaging can't be zipkin compatible since they are invalid for JMS (you can't have hyphens in header names).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants