Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the reference documentation to use more up-to-date examples #354

Closed
jearton opened this issue Jun 17, 2023 · 3 comments
Closed

Update the reference documentation to use more up-to-date examples #354

jearton opened this issue Jun 17, 2023 · 3 comments

Comments

@jearton
Copy link

jearton commented Jun 17, 2023

spring.version -> spring-framework.version

@jearton jearton changed the title An error in reference doc: no property of spring.version An error in reference doc: no property for spring.version Jun 17, 2023
@wilkinsona
Copy link
Contributor

Thanks for the report but I'm not sure what problem you're reporting. The examples in the docs are using the (now admittedly end-of-life) Spring IO Platform bom that does contain a spring.version property. Can you please be more specific?

@jearton
Copy link
Author

jearton commented Jun 17, 2023

@wilkinsona Oh, it's my fault. I imported Spring Boot Parent bom that is org.springframework.boot:spring-boot-dependencies:3.1.0 in which the spring version property is spring-framework.version

@wilkinsona
Copy link
Contributor

Cool. Thanks for the clarification. I don't think it would hurt to update the docs with some more up-to-date examples. We can use this issue to do that.

@wilkinsona wilkinsona changed the title An error in reference doc: no property for spring.version Update the reference documentation to use more up-to-date examples Jun 21, 2023
@wilkinsona wilkinsona modified the milestones: 1.1.1, 1.1.x Jun 21, 2023
@wilkinsona wilkinsona modified the milestones: 1.1.x, 1.1.1 Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants