Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentioning correct curl commands for Windows #118

Open
Vuizur opened this issue Oct 30, 2023 · 1 comment
Open

Mentioning correct curl commands for Windows #118

Vuizur opened this issue Oct 30, 2023 · 1 comment

Comments

@Vuizur
Copy link

Vuizur commented Oct 30, 2023

I think it would be nice to explicitly mention the correct CURL commands for Windows. The guide only mentions differences in the escaping rules, but this is hard to directly apply.

For example, on Powershell with Windows Terminal the following would work:

curl -X POST "localhost:8080/employees" -H "Content-type:application/json" -d "{\`"name\`": \`"Samwise Gamgee\`", \`"role\`": \`"gardener\`"}"
@robertmcnees
Copy link
Contributor

Hi @Vuizur. Thanks for the issue. You are right that the curl commands specified are not user friendly for those working on a Windows machine.

I see 4 instances in the guide where this comes up. Is that how many you see as well?

If there are a limited number of instances, I think it would be OK to add Windows commands as well. I hesitate to add too much duplication of instructions only for a different local environment, but a limited number is probably fine.

Would you like to submit a PR? I will mark this issue as help wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants