Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Irrelevant values in CachingConnectionFactory#toString #1560

Closed
arn-rio opened this issue Feb 3, 2023 · 2 comments · Fixed by #1564
Closed

Irrelevant values in CachingConnectionFactory#toString #1560

arn-rio opened this issue Feb 3, 2023 · 2 comments · Fixed by #1564
Assignees
@garyrussell
Labels
type: task
Milestone
3.0.2

Comments

@arn-rio
Copy link

arn-rio commented Feb 3, 2023

spring-amqp/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/connection/CachingConnectionFactory.java

Line 1044 in ccf202b

public String toString() {

Hello,

Host and port values should not be displayed when addresses attribute is defined (in AbstractConnectionFactory class) as connect method use addresses first.

Thanks.
@artembilan
Copy link
Member

We also can set an AddressResolver instead of all those.
Therefore it looks like it is better just to remove host/port from this CachingConnectionFactory.toString().

@garyrussell garyrussell added this to the 3.0.2 milestone Feb 7, 2023
@garyrussell garyrussell self-assigned this Feb 7, 2023
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Feb 7, 2023
@garyrussell
spring-projectsGH-1560: Caching CF toString() Improvements
0e8795e 
Resolves spring-projects#1560

Use address resolution hierarchy to determine destination host(s).
@garyrussell garyrussell mentioned this issue Feb 7, 2023
Merged
artembilan pushed a commit that referenced this issue Feb 7, 2023
@garyrussell
GH-1560: Caching CF toString() Improvements
2f48c79 
Resolves #1560

Use address resolution hierarchy to determine destination host(s).
@arn-rio
Copy link
Author

arn-rio commented Feb 8, 2023

Thanks for the fix. The message misled me while debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
type: task
Projects
None yet
Milestone
3.0.2
Development

Successfully merging a pull request may close this issue.

GH-1560: Caching CF toString() Improvements garyrussell/spring-amqp
3 participants
@garyrussell @artembilan @arn-rio