Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageProperties setDelay maximum value problem #2602

Closed
raylax opened this issue Jan 17, 2024 · 3 comments
Closed

MessageProperties setDelay maximum value problem #2602

raylax opened this issue Jan 17, 2024 · 3 comments

Comments

@raylax
Copy link
Contributor

raylax commented Jan 17, 2024

Integer maximum value 2147483647
but the maximum value for rabbitmq-delayed-message-exchange is (2^32)-1=4294967295
Is it a bug or a feature?

@artembilan
Copy link
Member

So, you idea is to let this header to be set to that 4294967295 as maximum?
Since the Integer cannot be more than 2147483647, we probably need to change it to the Long and validate respectively.

Is that what you think?

Thanks

@raylax
Copy link
Contributor Author

raylax commented Jan 17, 2024

Yeah, I think that's right.
But would it be better to change it to Longor add a method like setDelayLong?

My English is not good, Sorry.

@artembilan
Copy link
Member

Yes, setDelayLong() is good compromise for the current version.
We may mark the integer one as @Deprecated and will consider to remove it in the next version.

Please, consider to contribute such a fix: https://github.com/spring-projects/spring-amqp/blob/main/CONTRIBUTING.adoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants