Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Reference Links #2759

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Update Reference Links #2759

merged 2 commits into from
Jul 17, 2024

Conversation

ngocnhan-tran1996
Copy link
Contributor

I update some reference links.

I also delete message-converter-changes-1.adoc because I think message-converter-changes-1.adoc and message-converter-changes.adoc are the same.

Please check again and tell me if I miss something.

@pivotal-cla
Copy link

@ngocnhan-tran1996 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@artembilan
Copy link
Member

@ngocnhan-tran1996 ,

Please, sign CLA first, then we will be able to look into your contribution.

Thanks

@ngocnhan-tran1996
Copy link
Contributor Author

@ngocnhan-tran1996 ,

Please, sign CLA first, then we will be able to look into your contribution.

Thanks

@artembilan

I signed. Thank you

@artembilan
Copy link
Member

OK.
Let's see if this does the trick:

Click here to manually synchronize the status of this Pull Request.

!

Because the status on PR is still not valid.

@pivotal-cla
Copy link

@ngocnhan-tran1996 Thank you for signing the Contributor License Agreement!

@ngocnhan-tran1996
Copy link
Contributor Author

OK. Let's see if this does the trick:

Click here to manually synchronize the status of this Pull Request.

!

Because the status on PR is still not valid.

Thanks for this trick xD

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Please, also remove that message-converter-changes-1.adoc reference from the nav.adoc.

@ngocnhan-tran1996
Copy link
Contributor Author

Looks great!

Please, also remove that message-converter-changes-1.adoc reference from the nav.adoc.

I removed message-converter-changes-1.adoc in nav.adoc. Please review again.

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When PR build is green, I'll merge this.

Thank you for contribution; looking forward for more!

@artembilan artembilan merged commit 7886dd1 into spring-projects:main Jul 17, 2024
3 checks passed
@artembilan artembilan added this to the 3.2.0-M2 milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants