-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Reference Links #2759
Update Reference Links #2759
Conversation
@ngocnhan-tran1996 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
Please, sign CLA first, then we will be able to look into your contribution. Thanks |
I signed. Thank you |
OK.
! Because the status on PR is still not valid. |
@ngocnhan-tran1996 Thank you for signing the Contributor License Agreement! |
Thanks for this trick xD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Please, also remove that message-converter-changes-1.adoc
reference from the nav.adoc
.
I removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When PR build is green, I'll merge this.
Thank you for contribution; looking forward for more!
I update some reference links.
I also delete
message-converter-changes-1.adoc
because I thinkmessage-converter-changes-1.adoc
andmessage-converter-changes.adoc
are the same.Please check again and tell me if I miss something.