Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @ConditionalOnMissingServletInitializer #2158

Closed
philwebb opened this issue Dec 15, 2014 · 1 comment
Closed

Add @ConditionalOnMissingServletInitializer #2158

philwebb opened this issue Dec 15, 2014 · 1 comment
Labels
type: enhancement A general enhancement

Comments

@philwebb
Copy link
Member

#2148 can be fixed by subclassing CharacterEncodingFilter to add an order but it should have also been possible to use a FilterRegistrationBean with an explicit ordering. Unfortunately this wouldn't have worked because the @ConditionalOnBean guard would have failed. A @ConditionalOnMissingServletInitializer would be generally useful.
@philwebb philwebb added the type: enhancement A general enhancement label Dec 15, 2014
@philwebb philwebb added this to the 1.3.0 milestone Dec 15, 2014
@philwebb philwebb modified the milestones: 1.4.0, 1.3.0.RC1 Jul 10, 2015
@philwebb philwebb removed this from the 1.4.0 milestone Jan 8, 2016
@philwebb
Copy link
Member Author

philwebb commented Jan 8, 2016

Not sure what I was thinking here!

@philwebb philwebb closed this as completed Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philwebb