Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove any references to KeyValuesProviders and replace them with Observation.Conventions #31841

Closed
marcingrzejszczak opened this issue Jul 22, 2022 · 4 comments
Closed

Remove any references to KeyValuesProviders and replace them with Observation.Conventions #31841

marcingrzejszczak opened this issue Jul 22, 2022 · 4 comments
Assignees
@wilkinsona
Labels
theme: observability Issues related to observability type: task A general task
Milestone
3.0.0-RC1

Comments

@marcingrzejszczak
Copy link
Contributor

related PR: micrometer-metrics/micrometer#3306
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 22, 2022
@mhalbritter mhalbritter added type: task A general task theme: observability Issues related to observability and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 22, 2022
@mhalbritter mhalbritter added this to the 3.0.x milestone Jul 22, 2022
@adrianbob
Copy link
Contributor

Hey @marcingrzejszczak,
Can I take this issue?

@wilkinsona
Copy link
Member

Thanks for the offer @adrianbob, but we can't work on this yet as we're not ready to move to Micrometer snapshots.

@wilkinsona wilkinsona added the status: on-hold We can't start working on this issue yet label Jul 23, 2022
@wilkinsona
Copy link
Member

We no longer have any such references.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2022
@wilkinsona wilkinsona removed this from the 3.0.x milestone Oct 3, 2022
@wilkinsona wilkinsona added status: superseded An issue that has been superseded by another and removed status: on-hold We can't start working on this issue yet labels Oct 3, 2022
@wilkinsona
Copy link
Member

Actually, we have a test name and a configuration class that are still referring to key values providers despite now dealing with observation conventions.

@wilkinsona wilkinsona reopened this Oct 3, 2022
@wilkinsona wilkinsona removed the status: superseded An issue that has been superseded by another label Oct 3, 2022
@wilkinsona wilkinsona self-assigned this Oct 3, 2022
@wilkinsona wilkinsona added this to the 3.0.x milestone Oct 3, 2022
@wilkinsona wilkinsona modified the milestones: 3.0.x, 3.0.0-RC1 Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
theme: observability Issues related to observability type: task A general task
Projects
None yet
Milestone
3.0.0-RC1
Development

No branches or pull requests
5 participants
@wilkinsona @marcingrzejszczak @spring-projects-issues @adrianbob @mhalbritter