Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add R2DBC observation auto-configuration #33768

Closed
Tracked by #35776
ttddyy opened this issue Jan 11, 2023 · 5 comments
Closed
Tracked by #35776

Add R2DBC observation auto-configuration #33768

ttddyy opened this issue Jan 11, 2023 · 5 comments
Assignees
Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Milestone

Comments

@ttddyy
Copy link
Contributor

ttddyy commented Jan 11, 2023

Currently, the code exists in the spring experimental repository.
https://github.com/spring-projects-experimental/r2dbc-micrometer-spring-boot

This project provides Spring Boot auto configuration for Micrometer Tracing for R2DBC.
This ticket aims to move the code into Spring Boot.

@scottfrederick scottfrederick added the type: enhancement A general enhancement label Jan 11, 2023
@scottfrederick scottfrederick added this to the 3.1.x milestone Jan 11, 2023
@jonatan-ivanov jonatan-ivanov added the theme: observability Issues related to observability label Mar 1, 2023
@wilkinsona wilkinsona modified the milestones: 3.1.x, 3.x Apr 17, 2023
@travispeloton
Copy link

any updates on this?

@philwebb philwebb mentioned this issue Jun 7, 2023
31 tasks
@philwebb philwebb modified the milestones: 3.x, 3.2.x Jun 7, 2023
@mhalbritter mhalbritter self-assigned this Jul 24, 2023
@mhalbritter
Copy link
Contributor

To set the remote service, the ObservationProxyExecutionListener wants the R2DBC url. Reconstructing the R2DBC url when given a ConnectionFactory is hard, i've opened r2dbc/r2dbc-proxy#135 for an improvement. When r2dbc/r2dbc-proxy#135 is done, we can refactor the code in org.springframework.boot.actuate.autoconfigure.r2dbc.R2dbcObservationAutoConfiguration#extractUrl.

@mhalbritter mhalbritter modified the milestones: 3.2.x, 3.2.0-M2 Jul 25, 2023
@syz51
Copy link

syz51 commented Jan 8, 2024

hey there. I see this is closed and this feature is included in 3.2.0-M2 release. Is there any pointers to how to enable this auto-configuration now? When I use r2dbc and actuator, it doesn't seem to auto configure the tracing components automatically. Much appriatiated.

@bclozel
Copy link
Member

bclozel commented Jan 8, 2024

@syz51 you'll need the "io.r2dbc:r2dbc-proxy" dependency on your classpath.

@syz51
Copy link

syz51 commented Jan 8, 2024

@bclozel thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

9 participants