Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Producing and consuming different tracing propagation formats doesn't work #37161

Closed
michael-wirth opened this issue Aug 31, 2023 · 1 comment
Assignees
Labels
type: bug A general bug
Milestone

Comments

@michael-wirth
Copy link

The CompositeTextMapPropagator.java is using the same property for consumer and producer. I assume this is a copy-paste error.

See 9b72cc4#r126084189

Version

Spring Boot 3.1.3

Solution

Use the getEffectiveConsumedTypes() instead of the getEffectiveProducedTypes() method

Line 131: List<TextMapPropagator> extractors = properties.getEffectiveConsumedTypes().stream().map(mapper::map).toList();
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 31, 2023
@mhalbritter mhalbritter added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 1, 2023
@mhalbritter mhalbritter added this to the 3.0.x milestone Sep 1, 2023
@mhalbritter
Copy link
Contributor

mhalbritter commented Sep 1, 2023

Yes, that looks like a bug. Thank you!

The JavaDoc of org.springframework.boot.actuate.autoconfigure.tracing.CompositeTextMapPropagator#create is wrong, too. It references parameters which no longer exist.

@mhalbritter mhalbritter changed the title Support for multiple tracing propagation formats for consumers is not working. Producing and consuming different tracing propagation formats doesn't work Sep 1, 2023
@scottfrederick scottfrederick self-assigned this Sep 1, 2023
@scottfrederick scottfrederick modified the milestones: 3.0.x, 3.0.11 Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

4 participants