Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use spring.application.name as fallback for service.name in OtlpConfig #37285

Closed
mhalbritter opened this issue Sep 11, 2023 · 0 comments
Closed

Use spring.application.name as fallback for service.name in OtlpConfig #37285

mhalbritter opened this issue Sep 11, 2023 · 0 comments
Assignees
@mhalbritter
Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Milestone
3.2.0-M3

Comments

@mhalbritter
Copy link
Contributor

OtlpConfig automatically registers service.name from the env variable OTEL_SERVICE_NAME. If this env variable is not set, the SDK falls back to unknown_service.

In Spring Boot, we have spring.application.name, which we could fall back on.
@mhalbritter mhalbritter added type: enhancement A general enhancement theme: observability Issues related to observability labels Sep 11, 2023
@mhalbritter mhalbritter added this to the 3.2.x milestone Sep 11, 2023
@mhalbritter mhalbritter self-assigned this Sep 11, 2023
@mhalbritter mhalbritter mentioned this issue Sep 11, 2023
Closed
@mhalbritter mhalbritter modified the milestones: 3.2.x, 3.2.0-M3 Sep 11, 2023
@wilkinsona wilkinsona changed the title Use spring.application.name as service.name in OtlpConfig Use spring.application.name as fallback for service.name in OtlpConfig Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhalbritter mhalbritter

Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Projects
None yet
Milestone
3.2.0-M3
Development

No branches or pull requests
1 participant
@mhalbritter