Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align to Native Build Tools metadata repository default #39068

Closed
mhalbritter opened this issue Jan 9, 2024 · 8 comments
Closed

Align to Native Build Tools metadata repository default #39068

mhalbritter opened this issue Jan 9, 2024 · 8 comments
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: task A general task
Milestone

Comments

@mhalbritter
Copy link
Contributor

mhalbritter commented Jan 9, 2024

The native build tools plugin will change their metadata repository default from false to true in the future. When they did that, we can remove the code in the Boot plugins which sets this to true.

graalvm/native-build-tools#553

@mhalbritter mhalbritter added type: task A general task status: blocked An issue that's blocked on an external project change labels Jan 9, 2024
@mhalbritter mhalbritter added this to the 3.1.x milestone Jan 9, 2024
@mhalbritter
Copy link
Contributor Author

The PR to change the default has been merged: graalvm/native-build-tools#557

@mhalbritter mhalbritter modified the milestones: 3.1.x, 3.3.x Jan 19, 2024
@mhalbritter
Copy link
Contributor Author

NBT 0.10.0 has been released, which contains this change.

@mhalbritter mhalbritter removed the status: blocked An issue that's blocked on an external project change label Feb 5, 2024
@mhalbritter
Copy link
Contributor Author

mhalbritter commented Feb 5, 2024

Upgrade to NBT 0.10.0 done in #39398.

@mhalbritter mhalbritter modified the milestones: 3.3.x, 3.3.0-M2 Feb 5, 2024
@mhalbritter mhalbritter added the status: noteworthy A noteworthy issue to call out in the release notes label Feb 5, 2024
@wilkinsona
Copy link
Member

We should update start.spring.io as well so that it uses 0.10.0 with Boot 3.3 apps.

@mhalbritter
Copy link
Contributor Author

mhalbritter commented Feb 5, 2024

That should happen automatically. It should use the native build tools from Boot's dependency management (see NativeBuildtoolsVersionResolver). Maybe it's some cache that needs to be invalidated.

@mhalbritter
Copy link
Contributor Author

That's weird, it's still using 0.9.28. Will look into this.

@mhalbritter
Copy link
Contributor Author

It's not the cache. The newest version for the spring-boot-dependencies for 3.3.0-SNAPSHOT (https://repo.spring.io/ui/native/snapshot/org/springframework/boot/spring-boot-dependencies/3.3.0-SNAPSHOT/) is spring-boot-dependencies-3.3.0-20240204.151811-113.pom, from 2024-02-04, which still points to 0.9.28 of the NBT plugin.

Our builds are currently failing after the build phase (which itself is green), so no new snapshots have been published.

@mhalbritter
Copy link
Contributor Author

Now it has picked up the 0.10.0 version from Boot's dependency management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: task A general task
Projects
None yet
Development

No branches or pull requests

2 participants