Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for webjars-locator-lite #40146

Closed
sdeleuze opened this issue Apr 2, 2024 · 2 comments
Closed

Add support for webjars-locator-lite #40146

sdeleuze opened this issue Apr 2, 2024 · 2 comments
Assignees
@bclozel
Labels
type: enhancement A general enhancement
Milestone
3.4.0-M1

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Apr 2, 2024

As a follow-up to spring-projects/spring-framework#27619, when the related Spring Boot branch will be created, Spring Boot 3.4 should probably add support for org.webjars:webjars-locator-lite (0.0.3 has been released at this time, but 1.0.0 will be shortly released, see spring-projects/spring-framework#32564 and webjars/webjars-locator-lite#1 related issues).

In practice, I think that would mean updating ConditionalOnEnabledResourceChain to detect webjars-locator-lite org.webjars.WebJarVersionLocator, and add dependency management for org.webjars:webjars-locator-lite:1.0.0.

Notice org.webjars:webjars-locator-core support is deprecated as of Spring Framework 6.2.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 2, 2024
@scottfrederick scottfrederick added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 2, 2024
@scottfrederick scottfrederick added this to the 3.x milestone Apr 2, 2024
@sdeleuze
Copy link
Contributor Author

sdeleuze commented May 3, 2024

FYI org.webjars:webjars-locator-lite:1.0.0 has been released and will be used as a baseline as of Spring Framework 6.2.0-M2.

@wilkinsona wilkinsona modified the milestones: 3.x, 3.4.x May 3, 2024
@wilkinsona
Copy link
Member

Thanks, @sdeleuze. Sounds like a good candidate for Boot 3.4.

@bclozel bclozel self-assigned this Jun 17, 2024
@bclozel bclozel modified the milestones: 3.4.x, 3.4.0-M1 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.4.0-M1
Development

No branches or pull requests
5 participants
@scottfrederick @bclozel @sdeleuze @wilkinsona @spring-projects-issues