Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support testcontainers-redis #41450

Closed
wilkinsona opened this issue Jul 11, 2024 · 2 comments
Closed

Support testcontainers-redis #41450

wilkinsona opened this issue Jul 11, 2024 · 2 comments
Assignees
@wilkinsona
Labels
type: enhancement A general enhancement
Milestone
3.4.0-M3

Comments

@wilkinsona
Copy link
Member

Our support for Testcontainers and Redis currently relies on the container being named redis. We could add support for https://github.com/redis-developer/testcontainers-redis and its RedisContainer. With #41327, supporting RedisStackContainer (that uses redis/redis-stack-server) would also make sense.
@wilkinsona wilkinsona added the type: enhancement A general enhancement label Jul 11, 2024
@wilkinsona wilkinsona added this to the 3.x milestone Jul 11, 2024
@wilkinsona wilkinsona mentioned this issue Jul 11, 2024
Closed
@eddumelendez eddumelendez mentioned this issue Jul 17, 2024
Merged
@wilkinsona wilkinsona mentioned this issue Aug 21, 2024
Closed
@philwebb philwebb modified the milestones: 3.x, 3.4.x Aug 29, 2024
philwebb pushed a commit that referenced this issue Aug 30, 2024
@scottfrederick @philwebb
Add support for Testcontainer Redis
e7faca3 
Add support for the official `com.redis:testcontainers-redis` container.

See gh-41450
@philwebb philwebb modified the milestones: 3.4.x, 3.4.0-M3 Aug 30, 2024
@philwebb
Copy link
Member

🫡

@wilkinsona
Copy link
Member Author

Re-opening to look at supporting RedisStackContainer and to update the docs.

@wilkinsona wilkinsona reopened this Sep 5, 2024
@wilkinsona wilkinsona self-assigned this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.4.0-M3
Development

No branches or pull requests
3 participants
@scottfrederick @philwebb @wilkinsona