Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JmsListener failing with Narayana (pooled ConnectionFactory) since 3.4.0 #43277

Closed
graben opened this issue Nov 24, 2024 · 3 comments
Closed
Assignees
Labels
type: regression A regression from a previous release
Milestone

Comments

@graben
Copy link
Contributor

graben commented Nov 24, 2024

The unwrapping code introduced with commit into JmsAnnotationDrivenConfiguration is causing issue with Narayana integration if using pooled ConnectionFactory because it unwraps the integration "magic" away.

Reproduce with attached demo. Btw. Narayana integration from https://github.com/snowdrop/narayana-spring-boot needs to be rebuilt as SNAPSHOT because latest 3.3.0 version is not build compatible with Spring Boot 3.4.0. (snowdrop/narayana-spring-boot#172)

demo.zip

FYI @snicoll

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 24, 2024
@snicoll
Copy link
Member

snicoll commented Nov 25, 2024

Thanks for the sample, see also #39816.

is causing issue with Narayana

What does that mean? How do I reproduce the problem with the sample you've shared and what is the problem. I've tried to run the application and didn't see a problem except an exception on shutdown that can happen unfortunately with ActiveMQ. Nevermind, I see now that building Narayana is required.

@snicoll snicoll added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-feedback We need additional information before we can continue labels Nov 25, 2024
@snicoll
Copy link
Member

snicoll commented Nov 25, 2024

For those affected by the issue, you can add the following to your configuration to create a DefaultJmsListenerContainerFactory that doesn't do the unwrapping:

@Bean
DefaultJmsListenerContainerFactory jmsListenerContainerFactory(
		DefaultJmsListenerContainerFactoryConfigurer configurer, ConnectionFactory connectionFactory) {
	DefaultJmsListenerContainerFactory factory = new DefaultJmsListenerContainerFactory();
	configurer.configure(factory, connectionFactory);
	return factory;
}

@graben I've added the above in DemoApplication and that restored the behavior for now.

@snicoll snicoll changed the title JmsListener failing with Narayana (pooled ConnectionFactory) since 3.4.0 JmsListener failing with Narayana (pooled ConnectionFactory) since 6.2.0 Nov 25, 2024
@snicoll snicoll changed the title JmsListener failing with Narayana (pooled ConnectionFactory) since 6.2.0 JmsListener failing with Narayana (pooled ConnectionFactory) since 3.4.0 Nov 25, 2024
@graben
Copy link
Contributor Author

graben commented Nov 25, 2024

@snicoll: Thanks for the workaround. Works for me, too! ;-)

@snicoll snicoll added type: regression A regression from a previous release and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 25, 2024
@snicoll snicoll self-assigned this Nov 25, 2024
@snicoll snicoll added this to the 3.4.1 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression A regression from a previous release
Projects
None yet
Development

No branches or pull requests

3 participants