-
Notifications
You must be signed in to change notification settings - Fork 40.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve OpenTelemetry config #34518
improve OpenTelemetry config #34518
Conversation
- use opentelemetry-micrometer-1.5 bridge
- use opentelemetry-micrometer-1.5 bridge
@zeitlinger Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
group("io.opentelemetry") { | ||
imports = [ | ||
"opentelemetry-bom" | ||
"opentelemetry-bom-alpha" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure a stable version of Boot should depend on something that is unstable.
Also, right now upgrading OTel to anything higher than 1.20.1 will break baggage propagation in Micrometer Tracing.
|
||
@Bean | ||
@ConditionalOnMissingBean | ||
public MeterRegistry openTelemetryMeterRegistry(OpenTelemetry openTelemetry, Clock clock) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be auto-configured by OpenTelemetry I might be mistaken but I think they do. Also, Micrometer has an OTLP registry so if you want an OTLP output, you can use that (its auto-configured).
Thanks for the proposal, @zeitlinger. Unfortunately, moving to an OpenTelemetry alpha is a non-starter. We'd also like to let other related changes settle before considering any further changes in this area. Those changes are coming in Micrometer, Micrometer Tracing and #34508 and should all be available in 3.1.0-M2 that is to be released later this month. |
management.tracing.propagation
orotel.propagators
- not sure if this can be surprisingalpha
in otel, but haven't had any incompatible changes in the last months - I'll ask about it in the Java SIG