-
Notifications
You must be signed in to change notification settings - Fork 40.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Otlp Tracing's GRPC port from service connections #41333
Support Otlp Tracing's GRPC port from service connections #41333
Conversation
Otlp Tracing's exporter is configured using `Transport`. Current support for service connections read the mapped port for HTTP transport `4318`. This commits adds support to read port for GRPC transport `4317`.
Thanks for the PR, @eddumelendez. I'm not sure what the answer is, but this doesn't feel quite right to me. I don't think the connection details should have a separate method for the GRPC endpoint. Ideally, the existing |
Hi @wilkinsona, yes, I agree. I think that's the only way I was able to achieve it. Looking forward for any hint to update the PR. |
We discussed this today and we think we might be able to pass the |
Otlp Tracing's exporter is configured using `Transport`. Current support for service connections read the mapped port for HTTP transport `4318`. This commits adds support to read port for GRPC transport `4317`. See spring-projectsgh-41333
Placing on hold as we'd like to spend a bit of time thinking through our gRPC support across logs, metrics, and tracing. |
Otlp Tracing's exporter is configured using Transport. Current support for service connections read the mapped port for HTTP transport 4318. This commits adds support to read port for GRPC transport 4317. See gh-41333
Thanks! I've modified |
Otlp Tracing's exporter is configured using
Transport
. Current support for service connections read the mapped port for HTTP transport4318
. This commits adds support to read port for GRPC transport4317
.